Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's been YEARS! Lets improve the button design. #35

Open
oxalorg opened this issue Mar 25, 2020 · 8 comments
Open

It's been YEARS! Lets improve the button design. #35

oxalorg opened this issue Mar 25, 2020 · 8 comments

Comments

@oxalorg
Copy link
Owner

oxalorg commented Mar 25, 2020

I built this aiming simplicity. But the design has become a bit outdated.

Lets spice things up starting with buttons.

@meit-shah
Copy link

ok

@simondebbarma
Copy link

How can we move forward with this? I'd like to work on this.

I think we should discuss here a little on how you envision the changes should be and we can go back and forth on that @oxalorg.

@oxalorg
Copy link
Owner Author

oxalorg commented May 19, 2020

Thanks for the interest @0ww

To be honest on second thought the current buttons look just fine. It's simple and to the point. But maybe there is room for improvement. Do you have any ideas or inspiration? If so we can discuss on it.

Simplicity is important, along with not changing the design tooooo much. So keeping that in mind I think a few small tweaks can give us huge results:

  • Padding changes: if they're needed
  • Border Radius: if they're needed - making the buttons a bit softer/rounded but not too much. Something like 2 or 3px.

any other ideas?

@NitinNair89
Copy link

May I share my views?

  • border-radius: 5px
  • :hover, :focus effect

..and if SakuraCSS can be made accessible, that would be great!

Accessibility features:

  • color contrast
  • focus, tab visual indicator

If SakuraCSS is meant to be used without relying on full-fledged frameworks like Bootstrap of Bulma, then keeping its minimalism intact, few more features could be added.

For example, if I wished to use SakuraCSS for my personal blog, unfortunately I cannot. I always prefer the minimalist approach, but we may need a bit more.

I haven't used SakuraCSS, but I would definitely love to see it bloom further 🙂

@oxalorg
Copy link
Owner Author

oxalorg commented Oct 2, 2020

That's a great idea. A small border-radius will make it look a bit more modern.

I recently pushed a fix for contrast issues, it will be available in the next release.

unfortunately I cannot ... but we may need a bit more.

Can you expand a little more on that? I'm curious to understand what is preventing you from using sakura on your blog?

This is an example post on my blog with sakura: https://oxal.org/blog/fizzbuzz-in-clojure/

@NitinNair89
Copy link

NitinNair89 commented Oct 2, 2020

@oxalorg My blog is on wordpress. It's very heavy - https://www.nitinnairwrites.com/

Most of the features that I actively rely on are:

  • Ability to show featured post
  • Carousel
  • Responsiveness
    .. etc.

But I would love to have a minimal style that has all these features. It will drastically reduce the page load time. SakuraCSS is light-weight but maybe need more.

I would love to help, not sure how. 🙂

@oxalorg
Copy link
Owner Author

oxalorg commented Nov 26, 2020

@vkosnar That looks amazing! And yes I'm not very fond of rounded buttons, it works on some brands but for most sharp edges looks cleaner (also 100% agree with that bootstrap feeling haha).

If you want to contribute this as a PR feel free to do it, if not let me know and I'll add this to our next release :)

@AnshumanPadiya
Copy link

@oxalorg Hey am new here but, I do have a little suggestion to change the look and feel of the buttons both with some border-radius and little hover animation and onclick animation ( not using JS obvio)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants