-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-FOSS in F-Droid build - io.objectbox:objectbox-gradle-plugin #1298
Comments
Oh, boo. Obviously this is not ideal - I had thought (somehow) that objectbox was FOSS. Will resolve for the next release. Thanks for raising. |
@growse
And ended up with SQLDelight. All commits related to this can be found in LeoColman/Petals@b00f1e4...3.0.2 I tried to keep the history as clean and clear as possible to facilitate migration for others. |
Thanks, I was leaning towards Room but I'll have a look at the others. I've also got a branch here where I've removed the problematic gradle plugin and have just imported the object libraries directly (they're from maven, so not a problem). If I then "vendor" the plugin output classes into the codebase, everything seems to work. It doesn't feel like this is a long-term solution, but might be a short tactical way forward until a proper replacement can be found. Whether that's acceptable to F-Droid or not, I don't know. |
Reading Nonononoki/Hendroid#70 (comment) sounds like it's not gonna work? |
Oh, that's annoying. I wonder where in the source it's calling out to the native lib? |
Was fixed in #1436 |
@growse great, ping us when the release is tagged ;) |
@growse any eta ? Once again, big thanks for the effort :) |
Are there any blockers that prevents releasing this? |
It will be released when it's ready. |
yet the issues are closed, code merged and not on fdroid? I'm thankful for all open source projects, this one I am yet to try, but feel it would be beneficial to have a issue, that is open, tracking whatever is blocking the fdroid release. if fdroid is becoming more hassle than its worth for the project, it would be good to have that clarity. edit: i only post this as unless I have got mixed up, there has been releases on Github that contain these fixes, so there has been a release but seems not a submission to fdroid. |
I've been following these issues as I'd also like to see the app on F-Droid. The reason it's not there is the code changes haven't been released yet (there isn't a Github release, or a tagged version containing them). Although the subsequent releases v2.4.11 and v2.4.12 were made in August, chronologically after the objectbox work was merged in July, they were hotfix releases with some specific commits and did not contain all of the changes in The reason the work hasn't gone out appears to be because the changes take place in the middle of quite a lot of other development, which presumably isn't finished yet. Look at all the unreleased changes before: v2.4.12...19f306a (last release to replacing objectbox) and everything since: 19f306a...master. Hundreds of commits and files changed. I don't work on this project, but I'm guessing the developers are in the middle of a big refactor. A number of people have asked for details and offered to help, but in lieu of that I guess they would prefer the community to just be patient. Something the community might be able to do in the meantime is set up a custom F-Droid repository which builds the |
If being FOSS you mean? 😆 |
For those following this, owntracks |
Ref: https://github.com/owntracks/android/blob/v2.4.10-beta2/project/settings.gradle.kts#L11
Ref: objectbox/objectbox-java#560
Ref: https://gitlab.com/fdroid/fdroidserver/-/merge_requests/1150
The text was updated successfully, but these errors were encountered: