Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful shutdown #10430

Open
2 tasks
butonic opened this issue Oct 28, 2024 · 1 comment
Open
2 tasks

graceful shutdown #10430

butonic opened this issue Oct 28, 2024 · 1 comment
Labels

Comments

@butonic
Copy link
Member

butonic commented Oct 28, 2024

While #10412 we allows services to deregister themselves, we still cannot shutdown the reva runtime properly. We effectivley exit(0) after three secs of receiving a SIGTERM or SIGINT. decomposedfs is never notified of the shutdown.

We should

  • add a reva runtime.Shutdown(ctx) that allows a graceful shutdown like the http Server.
  • return /healthz healty = false as soon as the service is starting shutting down. This cannot be done with a simple port check AFAICT. might need a channel or atomic boolean?

cc @fschade

@jvillafanez
Copy link
Member

There was some work done in #9048 , but got stuck at the same point with the reva services.
I'm not sure how relevant that PR is with the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Qualification
Development

No branches or pull requests

2 participants