Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable seeking after switching to Backbonejs #421

Closed
pellaeon opened this issue Sep 3, 2015 · 5 comments
Closed

Re-enable seeking after switching to Backbonejs #421

pellaeon opened this issue Sep 3, 2015 · 5 comments
Assignees

Comments

@pellaeon
Copy link
Member

pellaeon commented Sep 3, 2015

Seeking is disabled now due to some AngularJS problem, seeking for FLAC and SoundManager2 supported format should be possible. We should re-enable seeking after switching to Backbone completely.

@pellaeon pellaeon self-assigned this Sep 3, 2015
@paulijar
Copy link
Collaborator

cc @gnarula
The seeking was enabled by #536. Seeking is still disabled with Aurora, but migrating to Backbonejs would not help on that. Hence, I'm proposing to close this issue.

@pellaeon
Copy link
Member Author

Some background on this, a year ago (I think) @MorrisJobke was going to rewrite the app with Backbonejs, so we decided to enable seeking after migration. But the migration never happened, so we could definitely enable it now.

What are the problems with seeking and Aurorajs now?

@gnarula
Copy link
Collaborator

gnarula commented Sep 14, 2016

Aurorajs' FLAC demuxer doesn't support seeking audiocogs/flac.js#8

@pellaeon
Copy link
Member Author

Ah, right, the issue can be closed by now.

@gnarula gnarula closed this as completed Sep 14, 2016
@paulijar
Copy link
Collaborator

@pellaeon Aurora.js' seeking for MP3 files, on the other hand, works but not with all files. With most of my MP3 files, attempting to seek caused the playback to be stopped and it could not be resumed. But with my newer MP3 files, seeking worked fine so it seems to be an issue in Aurora's mp3.js. Some seeking related change was recently merged to mp3.js (audiocogs/mp3.js#20), so it might be worth the shot to give it a new try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants