Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1.12 & FP-1.13: File Conflict Resolution #248

Open
dj4oC opened this issue Aug 19, 2023 · 6 comments
Open

FP-1.12 & FP-1.13: File Conflict Resolution #248

dj4oC opened this issue Aug 19, 2023 · 6 comments

Comments

@dj4oC
Copy link

dj4oC commented Aug 19, 2023

As a user of the Messenger with the integrated ownCloud Infinite Scale File Picker,
I want the File Picker to consistently detect potential file overwrites, provide me options for resolution, and handle naming in line with oCIS defaults,
So that I can confidently upload files without unwanted data loss or confusion and maintain naming uniformity.


Acceptance Criteria:

  1. Proactive File Name Detection:

    • During the upload process, the File Picker should actively check if the uploaded file/folder or files/folders might overwrite existing items in the destination.
  2. Clear Conflict Alert:

    • When a potential overwrite is detected, I should receive an unambiguous notification detailing the conflict.
  3. Comprehensive Resolution Options:

    • The File Picker should offer multiple choices upon conflict:
      • Cancel Upload: Terminate the current upload operation.
      • Replace: Overwrite the pre-existing file with the new upload.
      • Version: New upload becoming successor of the original.
      • Keep Both: Preserve both files independently, renaming the newly uploaded file to avoid a naming clash.
  4. oCIS-consistent Renaming:

    • If I select the "Keep Both" option, the File Picker should rename the new file or folder using the same default naming convention as oCIS (appending a number).
  5. Bulk Upload Handling:

  6. Visual Clarity:

    • The conflict resolution interface should be intuitive and easily distinguishable, possibly using distinct symbols or colors for each resolution choice.
  7. Confirmation Feedback:

    • Once the conflict is addressed and the upload process continues based on my choice, a confirmation should inform me of the successful conflict resolution.

cc @hodyroff @tbsbdr @JammingBen

@dj4oC
Copy link
Author

dj4oC commented Aug 22, 2023

@AversaFTW
Please review

@AversaFTW
Copy link

I think this requirement must be done by Sdui, because the messenger handles the uploads via an endpoint. The filepicker only displays all files inside the drive and is not involved in the upload. If I remember correctly, we have access to the whole file list and can check if there is a file with the same name already.

@dj4oC
Copy link
Author

dj4oC commented Aug 24, 2023

Would you mind if the return value is: "file exists" instead?
In that case you can send a message to the user: cancel, replace, version, keep both.
and send the request again with the selected option?

@AversaFTW
Copy link

Yes, that works.

@dj4oC
Copy link
Author

dj4oC commented Mar 2, 2024

@tbsbdr @kulmann Please check the test result:

siehe FP-1.08: File-Drop -> wird eine Datei hochgeladen, die den gleichen Namen hat wie eine bereits vorhandene Datei, wird die vorhandene überschrieben, ohne dass eine vorherige Abfrage erfolgt (Ersetzen, Abbrechen, Beide behalten)

@kulmann
Copy link
Member

kulmann commented Mar 2, 2024

The user story can't be fulfilled. Uploads are not handled within the file picker or web embed mode. The client that is performing the uploads is responsible for file naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants