Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send mail notification for shared files breaks if Collaborative Tags-App is disabled #31338

Closed
felixheidecke opened this issue May 3, 2018 · 8 comments · Fixed by #31498
Closed
Assignees
Labels
comp:core-js p2-high Escalation, on top of current planning, release blocker Type:Bug
Milestone

Comments

@felixheidecke
Copy link
Contributor

Steps to reproduce

  1. Disable Collaborative tags in the apps section
  2. Enable "Allow users to send mail notification for shared files" in sharing settings
  3. Create a public link share

Expected behaviour

Modal should should show sharing-form

Actual behaviour

Empty modal opens

Server configuration

Operating system:
any
Web server:
any
Database:
any
PHP version:
any
ownCloud version: (see ownCloud admin page)
10.0.8

Problem

select2 lib is provided by the Collaborative Tags-App and used in the mail notification process.

Javascript console log

this.$el.find(...).select2 is not a function

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #9770 (Disable "Share files" breaks files app), #4499 (Shared File Notifications), #12608 (Shared file notifications), #3465 (Sharing files), and #17829 (Disabling and re-enabling file sharing breaks files app).

@phil-davis
Copy link
Contributor

phil-davis commented May 3, 2018

@patrickjahns @individual-it this is where it will be good to have a test matrix that runs all the API and webUI acceptance tests with different combinations of apps disabled/enabled.

e.g. a first cut would be to disable all core-bundled apps that are possible for sysadmins to disable. Then let all the tests run (except of course tests specific to the disabled apps), and see what happens.

@felixboehm felixboehm added this to the development milestone May 3, 2018
@felixboehm felixboehm added the p3-medium Normal priority label May 3, 2018
@felixboehm
Copy link
Contributor

Please add a test to ensure we will not have regressions.

@individual-it
Copy link
Member

@phil-davis opened an issue for this kind of tests owncloud/QA#561

@PVince81
Copy link
Contributor

This was already reported to us here #31454 and also more people told me directly.

Increasing to p2 as release blocker for next release.

@PVince81 PVince81 added p2-high Escalation, on top of current planning, release blocker and removed p3-medium Normal priority labels May 17, 2018
@PVince81
Copy link
Contributor

leaving open until backport is done

@PVince81
Copy link
Contributor

will be released in 10.0.9 (next release)

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
comp:core-js p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants