[Bug] False positive [language_error] Method in Trait does not exist

[algo13]

<?php
trait T
{
    public function funcInT(){}
}
class C
{
    use T;
    public function funcInC()
    {
        $this->funcInT(); //< Notice:  Method funcInT() does not exist in C scope [language_error]
    }
}

... Maybe Mismatch between "key of Compiler::$traits" and "Compiler::getTrait() parameter".

[ovr]

Should be fixed now, can you try @algo13 ?

[algo13]

@ovr Thanks for comment.

• It fails when there is no NS.(If there is no NS, key of Compiler::$traits becomes \T)
• If you want to acquire NS, you can get it with $node->namespacedName->slice(0, -1).(Maybe unnecessary \PHPSA\Compiler\NameResolveVisitor)
• Node\Stmt\TraitUse::$traits was necessary to reference after NameResolver(resolveClassName in enterNode). (Use other NodeTraverser or leaveNode.)

Proposed amendment:

class Compiler
{
    // snip..
    public function addTrait(TraitDefinition $class)
    {
        $this->traits[(string)\PhpParser\Node\Name::concat($class->getNamespace(), $class->getName()])] = $class;
    }
    // snip..
}
class DefinitionVisitor extends NodeVisitorAbstract
{
    // snip..
    //public function enterNode(Node $node)
    public function leaveNode(Node $node)
    {
        // snip..
    }
    public function prepareTrait(Stmt\Trait_ $statement)
    {
        // snip..
        $namespace = $statement->namespacedName->slice(0, -1);
        if ($namespace !== null) {
            $definition->setNamespace($namespace);
        }
        // snip..
    }
    public function prepareClass(Stmt\Class_ $statement)
    {
        // snip..
            } elseif ($stmt instanceof Node\Stmt\TraitUse) {
                foreach ($stmt->traits as $traitPart) {
                    $traitDefinition = $this->compiler->getTrait((string)$traitPart);
                    if ($traitDefinition) {
                        $definition->mergeTrait($traitDefinition, $stmt->adaptations);
                    }
                }
            } elseif ($stmt instanceof Node\Stmt\ClassConst) {
        // snip..
    }
    // snip..
}

What do you think?

[ovr]

Continue working on this problem...