-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsoncpp cmake module not getting installed #459
Comments
Any progress on this? |
@themightyoarfish our documentation mentions that you need to install Do you still face the issue even when installing |
I've looked into this again, and on Ubuntu the problem does not appear to arise, as |
So even if macOS isn't supported as such, I'm curious why the custom cmake module is needed at all, when one is shipped with the apt package. |
I don't think you need to install list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/ouster-sdk/cmake) |
I think that supposes that i build the sdk as part of my toplevel cmake project, which I don't. i install it.
…On December 9, 2022 8:17:05 PM GMT+01:00, Ussama Naal ***@***.***> wrote:
> 've looked into this again, and on Ubuntu the problem does not appear to arise, as `libjsoncpp-dev` ships with cmake scripts (`/usr/lib/x86_64-linux-gnu/cmake/jsoncpp/jsoncppConfig.cmake` on 18.04) . On macos however, where many will install `jsoncpp` with homebrew, this does not hold. I guess this is more of a brew packaging issue, but it might still be worth installing the custom cmake modules like in #460.
> After all, on ubuntu this custom module shouldn't be needed at all, should it?
I don't think you need to install `Findjsoncpp.cmake` into your system to make use of it, if you are compiling the SDK you should be able to make use of the file simply by referencing the sdk cmake folder:
```cmake
list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/ouster-sdk/cmake)
```
--
Reply to this email directly or view it on GitHub:
#459 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Still a problem on current macos
|
It seems like the simple fix is just install the jsoncpp cmake module with the ouster library. |
And then you can't even use your own install of jsoncpp with the cmake integration (which homebrew seems to not have), because the ouster library links to a target called |
A change such as this fixes it: https://github.com/ouster-lidar/ouster-sdk/pull/618/files |
Client projects cannot compile against this project (when installed anyway), because
FindJsoncpp.cmake
is not getting installed alongside the rest. Whenfind_package()
ing ouster sdk:In my fork I had to make sure the module was installed.
The text was updated successfully, but these errors were encountered: