Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GenServer casts complete before continuing execution #78

Open
starcraft66 opened this issue Feb 18, 2024 · 0 comments
Open

Ensure GenServer casts complete before continuing execution #78

starcraft66 opened this issue Feb 18, 2024 · 0 comments

Comments

@starcraft66
Copy link
Member

We have many places in the code base like:

lanparty-seating/lib/lanpartyseating/logic/reservation_logic.ex

Line 146 in d91efb3

GenServer.cast(:"expire_reservation_#{res.id}", :terminate)

which directly fire calls to GenServer.cast/2 which only guarantees that the message was fired off but not that the task has actually done its job.

We should refactor these calls (cc: @berbiche)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@starcraft66