Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added exit button #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added exit button #39

wants to merge 1 commit into from

Conversation

andrew21-mch
Copy link
Contributor

@andrew21-mch andrew21-mch commented May 26, 2022 •
edited
Loading

fixes #37

Changes coming into this repo from this branch include:

  • Added the exit button and tried some implemented for the exit
    the exit function stops the button function such that even the start won't work
    I also saw another method that kills process and that is not an option because the bot will be hosted on a server and if the process is exited, that means its shutdown

I don't think any of the above is the desired exit

elhmn
elhmn reviewed Jun 6, 2022
View reviewed changes
Copy link
Member

@elhmn elhmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just that for a reason I ignore the exit button does not show up on the my menu bar. Do you know what my be causing that issue ?

Screenshot 2022-06-06 at 11 15 58

@andrew21-mch
Copy link
Contributor Author

This looks good, just that for a reason I ignore the exit button does not show up on the my menu bar. Do you know what my be causing that issue ?

Screenshot 2022-06-06 at 11 15 58

oh, yea, sure that was wrong screenshot
sreen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elhmn elhmn elhmn left review comments

@elroykanye elroykanye Awaiting requested review from elroykanye elroykanye is a code owner

@Mankavelda Mankavelda Awaiting requested review from Mankavelda Mankavelda is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an exit button on the menu
2 participants
@andrew21-mch @elhmn