Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Initial stuck to the name" - should be OK if Name Suggestions Index says so? #2399

Closed
osm-spiregrain opened this issue Nov 25, 2024 · 4 comments
Assignees
Labels

Comments

@osm-spiregrain
Copy link

Small point, but Osmose and NSI (as used for iD name suggestions) get into a fight when the name in NSI fails the "Initial stuck to the name" check. NSI has the name "H.Samuel", Osmose would prefer "H. Samuel". Should Osmose ignore "Initial stuck to the name" and similar name checks when NSI is asserting a different standardised name when if there is a brand:wikidata set?

Maybe this particular problem (H.Samuel/H. Samuel) should be fixed by fixing the NSI- but should Osmose skip these checks if there is a brand:wikidata set?

image

image

@Famlam
Copy link
Collaborator

Famlam commented Nov 25, 2024

Although we can technically couple NSI to a whitelist in the plugin (we do that in other plugins as well), I think here the NSI is wrong, because also the website of that shop lists it with a space in most places, e.g.
image
image

I see you already contacted them:
osmlab/name-suggestion-index#10171

@osm-spiregrain
Copy link
Author

Yes - if you read on, the shop doesn't seem to be very clear about it - they use both "H. Samuel" and "H.Samuel" on their website. I've suggested the NSI adopt the space.

My question for the osmose-backend maintainer/contributors is whether NSI entries should in general override 5010 / 902 and similar checks. I hadn't thought of the term 'whitelist', but that's exactly what I meant - so thank you.

@frodrigo
Copy link
Member

I think this check should be country dependent.

@Famlam
Copy link
Collaborator

Famlam commented Dec 11, 2024

Fix deployed, about 5000 cases less worldwide :)

@Famlam Famlam closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants