Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load method for the Extractor class is missing #138

Open
vetlewi opened this issue Jul 22, 2020 · 1 comment · May be fixed by #139
Open

Load method for the Extractor class is missing #138

vetlewi opened this issue Jul 22, 2020 · 1 comment · May be fixed by #139
Assignees
Labels
feature_request Requestion this feature

Comments

@vetlewi
Copy link
Collaborator

vetlewi commented Jul 22, 2020

The load() method for loading the state of the extractor from disk is missing. I will create a patch to add the feature.

@vetlewi vetlewi added the feature_request Requestion this feature label Jul 22, 2020
@vetlewi vetlewi self-assigned this Jul 22, 2020
@vetlewi vetlewi linked a pull request Jul 22, 2020 that will close this issue
@vetlewi vetlewi linked a pull request Jul 22, 2020 that will close this issue
@vetlewi
Copy link
Collaborator Author

vetlewi commented Aug 13, 2020

In 0fba72a I tried to address this by adding a static method that would load saved run from disk.

This differs from the convention introduced in the Matrix and Vector classes where

vector = om.Vector(path='path/to/vector.npy')
matrix = om.Matrix(path='path/to/matrix.npy')

will load these objects from file.

I guess my question is if it is desirable to use the same convention for the entire package?

If the answer above is yes, then one will probably need to remove the ensemble and trapezoid attributes in the Extractor class. Removing these attributes should be simple as these are only used in Extractor.extract_from() and functions called by this method. I will add the change to the draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request Requestion this feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant