Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koji_task_id is never set in the compose_status.json #122

Open
thozza opened this issue Aug 1, 2023 · 0 comments
Open

koji_task_id is never set in the compose_status.json #122

thozza opened this issue Aug 1, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@thozza
Copy link
Member

thozza commented Aug 1, 2023

The builder plugin's ComposeStatus implementation contains koji_task_id:

self.koji_task_id = task_id

and it sets it unconditionally when encoding it as a dict:
"koji_task_id": self.koji_task_id,

However, the ComposeStatus as returned by osbuild-composer API contains only Build ID:
https://github.com/osbuild/osbuild-composer/blob/f889be9e05d953aa63579dd7734815bece7a822c/internal/cloudapi/v2/openapi.v2.yml#L664-L669

As a result, the koji_task_id is always set to null in the compose_status.jsonuploaded to the Koji task. Example:
https://kojipkgs.fedoraproject.org//work/tasks/4169/103884169/compose-status.json

@thozza thozza added bug Something isn't working good first issue Good for newcomers labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant