Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update workers fleet (COMPOSER-1997) #126

Closed
wants to merge 4 commits into from
Closed

CI: Update workers fleet (COMPOSER-1997) #126

wants to merge 4 commits into from
+30 −20

Conversation

elkoniu
Copy link

@elkoniu elkoniu commented Nov 6, 2023

By default CI is running on RHEL 8, F36 and F37 workers. This commit adds Fedora 38 to the workers list
and removes deprecated Fedora 36

@ochosi
Copy link
Collaborator

ochosi commented Nov 6, 2023 •
edited
Loading

Neato! <3
I think you may also have to update the terraform and deploy.sh files in the schutzbot directory. See e.g. 32d9826

@elkoniu
Copy link
Author

elkoniu commented Nov 6, 2023

Neato! <3 I think you may also have to update the terraform and deploy.sh files in the schutzbot directory. See e.g. 32d9826

Looks like you are right. I will check result of the CI 1st, then will sync with Tomas on the morning to learn more about those files you mentioned. Thanks \o/

@elkoniu
Copy link
Author

elkoniu commented Nov 15, 2023

@ondrejbudai Last time I check (this night) all CI passed apart of RHEL 8.6. Added F38 succeded. I am wondering if it classifies this PR as accepted? I just retriggered RHEL 8.6 for the 3rd time (it fails at timeout at 4h time span).

@ondrejbudai
Copy link
Member

Ugh, the issue is that the cleanup scripts are never run, because the script just dies (due to set -e) after the test returns a non-zero exit code. However, this means that we have a leftover process in background, which unfortunately prevent the job to finish properly. I took the liberty of pushing a commit that hopefully fixes that. My dream is that if the job finishes properly (even though it fails), we should have access to some better logs.

@elkoniu
Copy link
Author

elkoniu commented Nov 20, 2023

Thank you for taking a look at this :)

I took the liberty of pushing a commit that hopefully fixes that. My dream is that if the job finishes properly (even though it fails), we should have access to some better logs.

So this issue is not related to my change? Shall I just rebase to the latest master and retrigger this PR on top of you changes?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 21, 2023
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Dec 28, 2023
@elkoniu elkoniu reopened this Jan 7, 2024
@elkoniu elkoniu linked an issue Jan 7, 2024 that may be closed by this pull request
Update CI for Fedora 38 #119
Open
@elkoniu
CI: Update workers fleet
197b77f 
By default CI is running on RHEL 8, F36 and F37 workers.
This commit adds Fedora 38 to the workers list
and removes deprecated Fedora 36
@elkoniu
Copy link
Author

elkoniu commented Jan 8, 2024

@ondrejbudai By mistake I have overwritten your fix for env cleanup and killing process leftovers. I tried to recreate your change out of memory and include in my change. Sorry for that.

@github-actions github-actions bot removed the Stale label Jan 8, 2024
@elkoniu elkoniu force-pushed the F38-worker-add branch 4 times, most recently from 1f2992b to 895ac7a Compare January 8, 2024 13:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 9, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Feb 17, 2024
@elkoniu elkoniu reopened this Feb 28, 2024
@github-actions github-actions bot removed the Stale label Feb 29, 2024
@ochosi ochosi changed the title CI: Update workers fleet CI: Update workers fleet (COMPOSER-1997) Apr 8, 2024
@elkoniu elkoniu closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejbudai ondrejbudai Awaiting requested review from ondrejbudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI for Fedora 38
3 participants
@elkoniu @ochosi @ondrejbudai