Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning applications to main menu #29

Closed
1 of 4 tasks
msjavan opened this issue Jan 29, 2020 · 10 comments
Closed
1 of 4 tasks

Pinning applications to main menu #29

msjavan opened this issue Jan 29, 2020 · 10 comments
Labels
enhancement New feature or request

Comments

@msjavan
Copy link

msjavan commented Jan 29, 2020

having ability to add applications to main menu in addition to categories.


Edited by @andersevenrud

  • Pinning via static configuration
  • Pinning via dynamic (user) configuration
    • Settings application ?
    • Custom dialog ?
@msjavan msjavan changed the title adding item to main menu directly adding applications to main menu Jan 29, 2020
@andersevenrud
Copy link
Member

Technically this should work, but I'm not sure about the best way to make it possible.

Right now a false-y category will make it default to "other" 🤔

@andersevenrud
Copy link
Member

I've started working on a possible solution for this: #31

What did you have in mind when enabling applications to show up on the root ?

  1. Have it as a setting on the panel item (per application)
  2. Have it as a setting on the client (per application)
  3. Have it as a metadata entry

@msjavan
Copy link
Author

msjavan commented Jan 30, 2020

  1. Have it as a metadata entry.
    For example if no category specified, goes to the root, or using an option to add favorite apps in the root.

@andersevenrud
Copy link
Member

andersevenrud commented Jan 30, 2020

Here's the thing though. An application should define a category. It's not just for UI reasons.

As I said, it falls back to "other" when nothing is defined.

So I'm thinking option number 2:

{
  application: {
    pinned: ['FileManager']
  }
}

@andersevenrud
Copy link
Member

Or, seeing down the road option 1 might be best -- because then users can for example open a dialog (or the settings app) to set what apps they want to pin themselves.

But this could be combined with 2 making it a global and per-user basis.

@msjavan
Copy link
Author

msjavan commented Jan 31, 2020

I agree, It would be good to pin apps per-user basis.

@andersevenrud
Copy link
Member

andersevenrud commented Jan 31, 2020

I've implemented option 2.

I need to finish panel item settings persistence before being able to work in option 1.

Edit - #33

@andersevenrud andersevenrud changed the title adding applications to main menu Pinning applications to main menu Feb 3, 2020
@andersevenrud
Copy link
Member

I've just published @osjs/[email protected] that supports the following client option to pin applications globally:

{
  application: {
    pinned: ['FileManager']
  }
}

@andersevenrud
Copy link
Member

@josephjeno You might have some use for this :)

@josephjeno
Copy link

@andersevenrud definitely!

@msjavan msjavan closed this as completed Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants