Build Unit Test failures after a076b9d7 ("Audit all transitive dependencies and fix latest vulnerabilities", 2024-12-27)

[bevanweiss]

@robmen / @barnson
Is anyone else seeing unit test failures when doing .\devbuild.cmd after commit a076b9d7?

[xUnit.net 00:00:02.93]     DutilTests.ApupUtil.AllocChainFromAtomSortsDescending [FAIL]
  Failed DutilTests.ApupUtil.AllocChainFromAtomSortsDescending [439 ms]
  Error Message:
   WixInternal.TestSupport.SucceededException : WixAssert.Succeeded() Failure
HRESULT:  0x80040154
Message:  Failed to parse feed: ...\wix\build\libs\Debug\x86\TestData\ApupUtilTests\FeedBv2.0.xml
  Stack Trace:
     at WixInternal.TestSupport.WixAssert.Succeeded(Int32 hr, String format, Object[] formatArgs) in ...\wix\src\internal\WixInternal.TestSupport\XunitExtensions\WixAssert.cs:line 85
   at WixInternal.TestSupport.NativeAssert.Succeeded(Int32 hr, SByte* zFormat, Char*[] wzArgs) in ...\wix\src\internal\WixInternal.TestSupport.Native\NativeAssert.h:line 64
   at DutilTests.ApupUtil.AllocChainFromAtomSortsDescending() in ...\wix\src\libs\dutil\test\DUtilUnitTest\ApupUtilTests.cpp:line 30
[xUnit.net 00:00:02.46]     DutilTests.MonUtil.MonUtilTest [SKIP]
[xUnit.net 00:00:02.47]     DutilTests.FileUtil.FileUtilTest [SKIP]
  Skipped DutilTests.MonUtil.MonUtilTest [1 ms]
  Skipped DutilTests.FileUtil.FileUtilTest [1 ms]
[xUnit.net 00:00:03.12]     DutilTests.LocUtil.CanLoadStringsWxl [FAIL]
  Failed DutilTests.LocUtil.CanLoadStringsWxl [455 ms]
  Error Message:
   WixInternal.TestSupport.SucceededException : WixAssert.Succeeded() Failure
HRESULT:  0x80040154
Message:  Failed to parse strings.wxl: ...\wix\build\libs\Debug\x64\TestData\LocUtilTests\strings.wxl
  Stack Trace:
     at WixInternal.TestSupport.WixAssert.Succeeded(Int32 hr, String format, Object[] formatArgs) in ...\wix\src\internal\WixInternal.TestSupport\XunitExtensions\WixAssert.cs:line 87
   at DutilTests.LocUtil.CanLoadStringsWxl() in ...\wix\src\libs\dutil\test\DUtilUnitTest\LocUtilTests.cpp:line 33
Results File: ...\wix\src\libs\..\..\build\logs\TestResults\libs.trx

Failed!  - Failed:     1, Passed:   102, Skipped:     2, Total:   105, Duration: 2 s - DUtilUnitTest.dll (netcoreapp1.0)
Failed!  - Failed:     1, Passed:   102, Skipped:     2, Total:   105, Duration: 2 s - DUtilUnitTest.dll (netcoreapp1.0)

[bevanweiss]

It looks like reverting the following changes resolves the test breaks (at least for me).

src/internal/WixInternal.TestSupport/WixInternal.TestSupport.csproj
index 4e1c3c26..1b713a0d 100644
@@ -4,7 +4,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;net472</TargetFrameworks>
+    <TargetFrameworks>net6.0;net472</TargetFrameworks>
     <IsPackable>true</IsPackable>
     <DebugType>embedded</DebugType>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>

src/wix/WixInternal.Core.TestPackage/WixInternal.Core.TestPackage.csproj
index 9d242b6c..99ffe620 100644
@@ -3,7 +3,7 @@
 
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net6.0;net472</TargetFrameworks>
     <Description>Internal WiX Toolset Test Package</Description>
     <DebugType>embedded</DebugType>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>

I think if we could get away with it, just having netstandard2.0 as the TargetFrameworks for these libraries should 'be fine'.
netstandard2.0 is supported on net461+ (although net472+ is recommended by MS)

[robmen]

Hmm, I'm not seeing that test failure, and more importantly, the build server isn't seeing it either. However, I tested reverting the net6.0 back to netstandard2.0 in WixInternal.TestSupport.csproj, which also seems to work. The net472 was still required for me to build native tests.

I have a PR (wixtoolset/wix#585) out with that change and a few small cleanup bits. I hope that helps address your local build issues.

[bevanweiss]

Hmm, I'm not seeing that test failure, and more importantly, the build server isn't seeing it either. However, I tested reverting the net6.0 back to netstandard2.0 in WixInternal.TestSupport.csproj, which also seems to work. The net472 was still required for me to build native tests.

I have a PR (wixtoolset/wix#585) out with that change and a few small cleanup bits. I hope that helps address your local build issues.

Still one failure remaining.

[xUnit.net 00:00:02.17]     DutilTests.LocUtil.CanLoadStringsWxl [FAIL]
  Failed DutilTests.LocUtil.CanLoadStringsWxl [420 ms]
  Error Message:
   WixInternal.TestSupport.SucceededException : WixAssert.Succeeded() Failure
HRESULT:  0x80040154
Message:  Failed to parse strings.wxl: ...\wix\build\libs\Debug\x86\TestData\LocUtilTests\strings.wxl
  Stack Trace:
     at WixInternal.TestSupport.WixAssert.Succeeded(Int32 hr, String format, Object[] formatArgs) in ...\wix\src\internal\WixInternal.TestSupport\XunitExtensions\WixAssert.cs:line 8     at WixInternal.TestSupport.WixAssert.Succeeded(Int32 hr, String format, Object[] formatArgs) in ...\wix\src\internal\WixInternal.TestSupport\XunitExtensions\WixAssert.cs:line 85
   at WixInternal.TestSupport.NativeAssert.Succeeded(Int32 hr, SByte* zFormat, Char*[] wzArgs) in ...\wix\src\internal\WixInternal.TestSupport.Native\NativeAssert.h:line 64
   at DutilTests.LocUtil.CanLoadStringsWxl() in ...\wix\src\libs\dutil\test\DUtilUnitTest\LocUtilTests.cpp:line 31

If I change things like net472=>net46, or net6.0=>netstandard2.0 then I can sometimes get a slightly different DUtil UnitText XML failure. Which perhaps leads to it being either XML related, or some concurrency issue with DUtil (if it's not just a bug somewhere in my build environment).

The build environment is;
Microsoft Windows [Version 10.0.27764.1000] (insider canary channel, so it's possibly this... but older commits work)
Microsoft Visual Studio Enterprise 2022 (64-bit) - Current (Version 17.12.3)
but I do also have Visual Studio Preview 2022 installed (maybe there is some cross contamination.. but again, older commits work)

[barnson]

I've intermittently gotten failures like that but they always go away on a rebuild. No previews.