v5.0.0RC2

[niden]

v5.0.0RC2

---

This discussion was created from the release v5.0.0RC2.

[s-ohnishi]

Since v5 is the RC version, I'd like to try it, but the online manual is still v4, and the phalcon/mvc sample can not be used as it is due to a series of errors.
Is there a sample that works with v5?
Since it is RC, I do not want detailed explanations.
It takes a lot of time and effort to search for changes in namespaces, method names, and arguments by relying on .zep and stub, so I need something that can be used as a reference.

Or should just non-developer users wait for the manual to be available?

[niden]

@s-ohnishi I made necessary corrections and wrote tests to see that the code from style() etc. is correctly generated using Volt. This will be out in the next RC which will be this week.

Thank you for reporting this.

[s-ohnishi]

That's good news.
I am very much looking forward.

[s-ohnishi]

I tried RC3.
I was able to output the value set in the controller in .volt.
Thank you very much.

SomeController::
$this->tag->doctype(\Phalcon\Tag::HTML401_TRANSITIONAL, PHP_EOL);

.volt::
{{ tag.newInstance('doctype') }}

But when I use {{ tag.doctype() }} in .volt, <! DOCTYPE html> is returned.

I may not understand Zephir exactly

TagFactory::
    public function __call(string name, array arguments)
    {
        var helper;
        let helper = this->newInstance(name);
        return call_user_func_array([helper, "__invoke"], arguments);
    }

Doctype::
    public function __invoke(
        int flag = self::HTML5,
        string delimiter = "\n"
    ) -> <Doctype> {
        let this->flag      = flag,
        this->delimiter = delimiter;
        return this;
    }

Doesn't this always return a new instance with tag.doctype()?

For example, if you make it like this, tag.tagname () will return the instance if it is registered, register the instance using arguments if it is not registered, and return it?
And in order to make newInstance () a feature that matches the name, I think we should just overwrite the existing service with a "new" instance and return it.

TagFactory::

    public function __call(string name, array arguments = [])
    {
        var helper;
        if !isset this->services[name] {
            let helper = this->newInstance(name);
            this->services[name] = call_user_func_array([helper, "__invoke"], arguments);
        }
        return this->services[name];
    }

    public function newInstance(string name) -> var
    {
        var definition;

        let definition = this->getService(name),
        this->services[name] = create_instance_params(
            definition,
            [
                this->escaper
            ]
        );

        return this->services[name];
    }

I don't understand zephir, and I don't know how it affects others, but I hope it conveys what I mean.

[niden]

This seems indeed a bit weird. Let me test it a bit and explain it to my head first and then I will share lol.

In theory, the TagFactory is a locator service that creates objects and stores them to be reused within the same request. The newInstance creates a new object only if not present - that is the design at least.

There is something I don't like in the __call method. I need to check it.

Also for the doctype method you use, it should return the transitional string. Let me test it first and will post results shortly.

[s-ohnishi]

In the current situation, the __call method always returns a new instance, and newInstance() may return an existing (= old) instance, so I think the function is the opposite.
And current newInstance() can only pass the name, it feels inconvenient not to pass a parameter.
(I forgot to include that part in the previous reply)

I will wait for your test results to be shown.

[kgrammer]

@niden, I have the tutorial file for Phalcon 5 ready to send to you. You can message me on Discord with instructions on where you would like me to send the zip file.

[zikezhang]

FYI, if you can not find the documentation and occurred some Fatal Error like

Fatal Error: Class "Phalcon\Config" not found

you can go to the source page
https://github.com/phalcon/cphalcon/tree/master/phalcon

and find the path of the namespace, it's straightforward.

[s-ohnishi]

Thank you very much.
I know that page, and I often follow it from that page when I want to find out what parameters I can specify and what I'm doing.
However, in this case, the problem was that "nothing was displayed" instead of an error.

PhpStorm does a good job, so you don't have to worry too much about namespaces.
But, sometimes the stub is wrong and displays a warning.
I found another one.

  * @method label (array $ attributes = []): string

phalcon / Html / Helper / Label.zep

public function __invoke (string $ label, array $ attributes = [], bool $ raw = false): string