"equal or after" scenario in "after" and "before" validator

[Vong3432]

Hello there 👋,

I have been using the validators quite a while and so far I think it is very easy and good to use. Recently I have faced some scenarios where a date have to be either same with today or after today.

Example scenario

Given

• Current date: 2021-12-29
• John wants to have a holiday on 2021-12-29
• Today is 2021-12-29

Validator requirement

• The date should be either today or after today. But any date before today is invalid.

My current approach

// valid 
rules.after(-1, "day")

// invalid
rules.after(0, "day")
rules.after("today") 

Ideal approach

rules.after("today", { equalTo: true })

Documentation

Although my current approach worked and the documentation did mention how we can add a custom ref to handle more advanced usage, but the code itself looks kinda weird and not easy to understand at first sight.

Would it be better if we can have an extra optional parameters in the after validator to handle these scenarios?

[thetutlage]

How about adding two new rules. beforeOrEqual and afterOrEqual? In your case it will be afterOrEqual('today')

[Vong3432]

Looks good!

[thetutlage]

Do you think you can create a PR for the same?

[Vong3432]

I can give it a try. Should that PR be created in adonis/validator repo?