[m4] Please port gnulib fseeko.c to your platform! #263

hutson · 2020-12-11T01:21:14Z

hutson
Dec 11, 2020

Running into difficulties installing formulas that have a dependency on m4, including neovim, git, etc. Compiling the m4 package is required because, as seen in my brew doctor output, I use a non-standard Homebrew directory. Therefore packages are built from source instead of installed from bottles.

Unfortunately that compile fails.

$ brew update
Already up-to-date.


$ brew update
Already up-to-date.


$ brew install m4
Warning: Building m4 from source as the bottle needs:
- HOMEBREW_CELLAR: any_skip_relocation (yours is /home/hutson/.linuxbrew/Cellar)
- HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew (yours is /home/hutson/.linuxbrew)
- HOMEBREW_REPOSITORY: /home/linuxbrew/.linuxbrew/Homebrew (yours is /home/hutson/.linuxbrew/Homebrew)
==> Downloading https://ftp.gnu.org/gnu/m4/m4-1.4.18.tar.xz
######################################################################## 100.0%
==> ./configure --prefix=/home/hutson/.linuxbrew/Cellar/m4/1.4.18
==> make
Last 15 lines from /home/hutson/.cache/Homebrew/Logs/m4/02.make:
      |   ^~~~~
make[3]: *** [Makefile:1915: freadahead.o] Error 1
make[3]: *** Waiting for unfinished jobs....
  CC       obstack.o
fseeko.c: In function 'rpl_fseeko':
fseeko.c:110:4: error: #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
  110 |   #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
      |    ^~~~~
make[3]: *** [Makefile:1915: fseeko.o] Error 1
make[3]: Leaving directory '/tmp/m4-20201210-737477-6wlgue/m4-1.4.18/lib'
make[2]: *** [Makefile:1674: all] Error 2
make[2]: Leaving directory '/tmp/m4-20201210-737477-6wlgue/m4-1.4.18/lib'
make[1]: *** [Makefile:1572: all-recursive] Error 1
make[1]: Leaving directory '/tmp/m4-20201210-737477-6wlgue/m4-1.4.18'
make: *** [Makefile:1528: all] Error 2

READ THIS: https://docs.brew.sh/Troubleshooting


$ brew config
HOMEBREW_VERSION: 2.6.1-27-g06c60b9
ORIGIN: https://github.com/Homebrew/brew
HEAD: 06c60b98924610b9c6707ff857b4f99039eb6266
Last commit: 2 hours ago
Core tap ORIGIN: https://github.com/Homebrew/linuxbrew-core
Core tap HEAD: 07337e40aba8dedfe81f095a6dff2d0f9933df05
Core tap last commit: 7 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /home/hutson/.linuxbrew
HOMEBREW_REPOSITORY: /home/hutson/.linuxbrew/Homebrew
HOMEBREW_CELLAR: /home/hutson/.linuxbrew/Cellar
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0
HOMEBREW_EDITOR: nano
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_ANALYTICS: set
Homebrew Ruby: 2.6.3 => /home/hutson/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: octa-core 64-bit skylake
Clang: N/A
Git: 2.25.1 => /bin/git
Curl: 7.68.0 => /usr/bin/curl
Kernel: Linux 5.4.0-56-generic x86_64 GNU/Linux
OS: Ubuntu 20.04.1 LTS (focal)
Host glibc: 2.31
/usr/bin/gcc: 9.3.0
/usr/bin/ruby: N/A
glibc: N/A
gcc: N/A
xorg: N/A


$ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Your Homebrew's prefix is not /home/linuxbrew/.linuxbrew.
Some of Homebrew's bottles (binary packages) can only be used with the default
prefix (/home/linuxbrew/.linuxbrew).
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
unsupported configuration.


$ cat /home/hutson/.cache/Homebrew/Logs/m4/02.make
2020-12-10 19:14:36 -0600

make

/usr/bin/make  all-recursive
make[1]: Entering directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18'
Making all in .
make[2]: Entering directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18'
make[2]: Nothing to be done for 'all-am'.
make[2]: Leaving directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18'
Making all in examples
make[2]: Entering directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18/examples'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18/examples'
Making all in lib
make[2]: Entering directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18/lib'
  GEN      alloca.h
  GEN      configmake.h
  GEN      c++defs.h
  GEN      arg-nonnull.h
  GEN      warn-on-use.h
  GEN      limits.h
  GEN      unused-parameter.h
  GEN      fcntl.h
  GEN      sys/types.h
  GEN      langinfo.h
  GEN      locale.h
  GEN      math.h
  GEN      signal.h
  GEN      spawn.h
  GEN      stdio.h
  GEN      string.h
  GEN      stdlib.h
  GEN      sys/stat.h
  GEN      sys/time.h
  GEN      sys/wait.h
  GEN      time.h
  GEN      unistd.h
  GEN      wchar.h
  GEN      wctype.h
/usr/bin/make  all-am
make[3]: Entering directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18/lib'
  CC       gl_avltree_oset.o
  CC       binary-io.o
  CC       c-ctype.o
  CC       c-stack.o
  CC       c-strcasecmp.o
  CC       c-strncasecmp.o
  CC       clean-temp.o
  CC       cloexec.o
  CC       close-stream.o
  CC       closein.o
  CC       closeout.o
  CC       dirname.o
  CC       basename.o
  CC       dirname-lgpl.o
  CC       basename-lgpl.o
  CC       stripslash.o
  CC       execute.o
  CC       fatal-signal.o
  CC       exitfail.o
  CC       fd-hook.o
  CC       fd-safer-flag.o
  CC       filenamecat.o
  CC       dup-safer-flag.o
  CC       filenamecat-lgpl.o
  CC       fopen-safer.o
  CC       freading.o
  CC       getprogname.o
  CC       hard-locale.o
  CC       gl_linkedhash_list.o
  CC       gl_list.o
  CC       localcharset.o
  CC       malloca.o
  CC       math.o
  CC       gl_oset.o
  CC       memchr2.o
  CC       pipe2.o
  CC       printf-frexp.o
  CC       pipe2-safer.o
  CC       printf-frexpl.o
  CC       progname.o
  CC       quotearg.o
  CC       sig-handler.o
  CC       spawn-pipe.o
  CC       mkstemp-safer.o
  CC       tempname.o
  CC       glthread/threadlib.o
  CC       glthread/tls.o
  CC       tmpdir.o
  CC       unistd.o
  CC       dup-safer.o
  CC       fd-safer.o
  CC       pipe-safer.o
  CC       verror.o
  CC       version-etc.o
  CC       wait-process.o
  CC       version-etc-fsf.o
  CC       wctype-h.o
  CC       xmalloc.o
  CC       xalloc-die.o
  CC       gl_xlist.o
  CC       xmalloca.o
  CC       gl_xoset.o
  CC       xprintf.o
  CC       xsize.o
  CC       xstrndup.o
  CC       xvasprintf.o
  CC       xasprintf.o
  CC       asnprintf.o
  CC       asprintf.o
  CC       fclose.o
  CC       fcntl.o
  CC       fflush.o
  CC       fpurge.o
  CC       freadahead.o
  CC       fseek.o
  CC       fseeko.o
freadahead.c: In function 'freadahead':
freadahead.c:92:3: error: #error "Please port gnulib freadahead.c to your platform! Look at the definition of fflush, fread, ungetc on your system, then report this to bug-gnulib."
   92 |  #error "Please port gnulib freadahead.c to your platform! Look at the definition of fflush, fread, ungetc on your system, then report this to bug-gnulib."
      |   ^~~~~
  CC       mbrtowc.o
make[3]: *** [Makefile:1915: freadahead.o] Error 1
make[3]: *** Waiting for unfinished jobs....
  CC       obstack.o
fseeko.c: In function 'rpl_fseeko':
fseeko.c:110:4: error: #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
  110 |   #error "Please port gnulib fseeko.c to your platform! Look at the code in fseeko.c, then report this to bug-gnulib."
      |    ^~~~~
make[3]: *** [Makefile:1915: fseeko.o] Error 1
make[3]: Leaving directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18/lib'
make[2]: *** [Makefile:1674: all] Error 2
make[2]: Leaving directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18/lib'
make[1]: *** [Makefile:1572: all-recursive] Error 1
make[1]: Leaving directory '/tmp/m4-20201210-744499-7k5ecv/m4-1.4.18'
make: *** [Makefile:1528: all] Error 2

HOMEBREW_VERSION: 2.6.1-27-g06c60b9
ORIGIN: https://github.com/Homebrew/brew
HEAD: 06c60b98924610b9c6707ff857b4f99039eb6266
Last commit: 2 hours ago
Core tap ORIGIN: https://github.com/Homebrew/linuxbrew-core
Core tap HEAD: 07337e40aba8dedfe81f095a6dff2d0f9933df05
Core tap last commit: 7 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /home/hutson/.linuxbrew
HOMEBREW_REPOSITORY: /home/hutson/.linuxbrew/Homebrew
HOMEBREW_CELLAR: /home/hutson/.linuxbrew/Cellar
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0
HOMEBREW_EDITOR: nano
HOMEBREW_MAKE_JOBS: 8
HOMEBREW_NO_ANALYTICS: set
Homebrew Ruby: 2.6.3 => /home/hutson/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: octa-core 64-bit skylake
Clang: N/A
Git: 2.25.1 => /bin/git
Curl: 7.68.0 => /usr/bin/curl
Kernel: Linux 5.4.0-56-generic x86_64 GNU/Linux
OS: Ubuntu 20.04.1 LTS (focal)
Host glibc: 2.31
/usr/bin/gcc: 9.3.0
/usr/bin/ruby: N/A
glibc: N/A
gcc: N/A
xorg: N/A

HOMEBREW_CC: gcc-9
HOMEBREW_CXX: g++-9
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /home/hutson/.linuxbrew
HOMEBREW_GIT: git
ACLOCAL_PATH: /home/hutson/.linuxbrew/share/aclocal
PATH: /home/hutson/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super:/usr/bin:/bin:/usr/sbin:/sbin

hutson · 2020-12-11T01:29:40Z

hutson
Dec 11, 2020
Author

Force installing the bottle does not work either:

$ brew install m4 --force-bottle
==> Downloading https://linuxbrew.bintray.com/bottles/m4-1.4.18.x86_64_linux.bottle.tar.gz
Already downloaded: /home/hutson/.cache/Homebrew/downloads/9fbd4721316274995db37b5f92441b550d09bd131339ecc447377ee886970363--m4-1.4.18.x86_64_linux.bottle.tar.gz
Error: undefined method `stage' for nil:NilClass
Please report this issue:
  https://docs.brew.sh/Troubleshooting
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:1130:in `block in pour'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/extend/pathname.rb:318:in `block in cd'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/extend/pathname.rb:318:in `chdir'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/extend/pathname.rb:318:in `cd'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:1129:in `pour'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:393:in `install'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:384:in `install_formula'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:297:in `block in install'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:295:in `each'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:295:in `install'
/home/hutson/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'

0 replies

carlocab · 2020-12-11T01:39:40Z

carlocab
Dec 11, 2020

It might be difficult for you to get help here due to the unsupported installation prefix.

Have you looked through the gnu-lib mailing list to see if someone's had a similar experience with fseeko.{c,o}?

7 replies

hutson Dec 11, 2020
Author

Using this patch - https://gist.github.com/hutson/500cc2a6b3dd6033b783da2ade90750f#file-m4-patch

I was able to successfully install m4:

brew install m4
Warning: Building m4 from source as the bottle needs:
- HOMEBREW_CELLAR: any_skip_relocation (yours is /home/hutson/.linuxbrew/Cellar)
- HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew (yours is /home/hutson/.linuxbrew)
- HOMEBREW_REPOSITORY: /home/linuxbrew/.linuxbrew/Homebrew (yours is /home/hutson/.linuxbrew/Homebrew)
==> Downloading https://gist.githubusercontent.com/hutson/500cc2a6b3dd6033b783da2ade90750f/raw/c278ddff57d5e46ef4f2f70d84725d23014bf4ab/m4.patch
Already downloaded: /home/hutson/.cache/Homebrew/downloads/5e47c86b5f78c0c8c363ccf76cf8c0ebad41714b706afb47d81e604516141a74--m4.patch
==> Downloading https://ftp.gnu.org/gnu/m4/m4-1.4.18.tar.xz
Already downloaded: /home/hutson/.cache/Homebrew/downloads/bb74c92bda9bdc32be0653ca50751920ff35cfe8f329499d0bea86fbe66ce580--m4-1.4.18.tar.xz
==> Patching
==> Applying m4.patch
patching file lib/fflush.c
patching file lib/fpending.c
patching file lib/fpurge.c
patching file lib/freadahead.c
patching file lib/freading.c
patching file lib/fseeko.c
patching file lib/stdio-impl.h
==> ./configure --prefix=/home/hutson/.linuxbrew/Cellar/m4/1.4.18
==> make
==> make install
🍺  /home/hutson/.linuxbrew/Cellar/m4/1.4.18: 13 files, 646.7KB, built in 39 seconds
Removing: /home/hutson/.cache/Homebrew/m4--patch--7a0fb22767d7f4a4c9aaaa2b7823776ac1a8d9b50fb95e4fcd1b78726873d055.patch... (5.4KB)
Removing: /home/hutson/.cache/Homebrew/m4--patch--a822711235c80194eab9287f850f7101d0cc31281aad9c6938a53207098f0d1a.patch... (4.8KB)
Removing: /home/hutson/.cache/Homebrew/m4--patch--11124c35afc83deac14ae6a9d9ece546cc446bd82758df66298021a3a19cefb9.patch... (7.6KB)
Removing: /home/hutson/.cache/Homebrew/m4--patch--740d55a705b31e90d9727dd49e8b080a958d697a8939f9ff31301160de07c0cb.patch... (5KB)
Removing: /home/hutson/.cache/Homebrew/m4--patch--c6fc066016284b2149efce26966abdfa3937e986b50bddf6e08be11c61f96e1c.patch... (6.2KB)
Removing: /home/hutson/.cache/Homebrew/m4--patch--bd4bae3ff823d4c95b9ee548ec0b00885291ff16fc67834cbd8dcea5fe8617ce.patch... (4.8KB)
Removing: /home/hutson/.cache/Homebrew/m4--patch--7851ce0dff59d5b27eecf3ef9e6ae0077d47aeb14fabd45022b1a65f2351ebfe.git... (12.3KB)

There are formulae with patches in linuxbrew-core

Thankfully, or maybe not, I have a little experience with patching Homebrew (Linuxbrew back when I was working on a 32-bit system).

What I don't know is how to say "only apply this patch if the version of glibc is version 2.28 or later".

I should mention that there is a somewhat high bar for patches to be accepted into formulae for Homebrew

That seems quite reasonable. Thankfully this patch is only needed until m4 version 1.4.19 is released, and it only applies if you are using glibc 2.28 or newer.

It might help to demonstrate that this is an issue that also affects installations in the default prefix.

I suspect not in the default case since the m4 bottle would be installed in the standard prefix directory. Perhaps I can force the install to build from source and reproduce this issue.

It's a little extra work that I would be willing to do, but I would like to know it's reasonable for a patch like this to be incorporated into linuxbrew-core given the caveat around the glibc version.

carlocab Dec 11, 2020

Glad you got m4 working.

What I don't know is how to say "only apply this patch if the version of glibc is version 2.28 or later".

I don't know this either. However, brew does check the system's version of glibc, so I imagine there is a way. grepping the linuxbrew-core repo may give you some ideas for how to do it.

Given you have a working patch, if you're unable to figure out how to implement a version check for glibc, it may be worth opening an issue at linuxbrew-core to ask. (Maybe -- please double check their guidelines on opening issues before you do.)

jonchang Dec 11, 2020

What I don't know is how to say "only apply this patch if the version of glibc is version 2.28 or later".

Will m4 still build with glibc < 2.28 if this patch is applied?

Thankfully this patch is only needed until m4 version 1.4.19 is released, and it only applies if you are using glibc 2.28 or newer.

Does upstream already have a fix for glibc > 2.28? Ideally we would just use an upstream patch instead of including our own. https://git.savannah.gnu.org/cgit/m4.git/log/?h=branch-1.4

hutson Dec 11, 2020
Author

so I imagine there is a way. grepping the linuxbrew-core repo may give you some ideas for how to do it.

Thank you again @carlocab for the nudge 😅

After a quick search I came across the Perl formula which appears to check the glibc version - https://github.com/Homebrew/linuxbrew-core/blob/e60203178d890bfa2384306f75945757cd842f92/Formula/perl.rb#L77

Will m4 still build with glibc < 2.28 if this patch is applied?

@jonchang I do not know given my limited knowledge about gnulib and glibc.

Does upstream already have a fix for glibc > 2.28?

Yes, kind of. Gnulib contains a patch, the one I came across on the bug-m4 mailing list.

However, that patch is applied to gnulib, which m4 bundles as part of its distribution (The tar.xz file contains a lib/ directory that is a copy of gnulib, a practice mentioned in their distribution README: Some files in the distribution are copied from the gnulib project

So, I went looking again for a patch that could be applied directly to the m4 distribution.

I came across this post from September 12, 2020 - https://lists.gnu.org/archive/html/bug-m4/2020-09/msg00001.html

That post points to a patch that Arch Linux maintains against the 1.4.18 distribution ( A patch that is a little more authoritative than mine) - https://github.com/archlinux/svntogit-packages/blob/packages/m4/trunk/m4-1.4.18-glibc-change-work-around.patch

There's a post about the large number of issues Linux and Mac users have run into because of the outdated gnulib files - https://lists.gnu.org/archive/html/bug-m4/2020-03/msg00000.html

It does appear the person keeps a snapshot of the latest output from executing ./boostrap on the branch-1.4 branch - https://gitlab.com/gnu-m4/ci-distcheck/-/jobs/artifacts/master/raw/m4-snapshot.tar?job=check-optimized

Unfortunately it's not a fixed release, but tracks the branch.

hutson Dec 12, 2020
Author

@carlocab @jonchang I submitted a pull request against homebrew-core here - Homebrew/homebrew-core#66763

MarDiehl · 2020-12-11T07:41:35Z

HOMEBREW_VERSION: 2.6.1-29-g2be340c
ORIGIN: https://github.com/Homebrew/brew
HEAD: 2be340c6d6495774c891fbd2d3af37614d3c89d0
Last commit: 5 hours ago
Core tap ORIGIN: https://github.com/Homebrew/linuxbrew-core
Core tap HEAD: 84b042c9568ef1cabf1851c3d255718fe166c954
Core tap last commit: 76 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /home/d/.linuxbrew
HOMEBREW_REPOSITORY: /home/d/.linuxbrew/Homebrew
HOMEBREW_CELLAR: /home/d/.linuxbrew/Cellar
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vim
HOMEBREW_MAKE_JOBS: 32
Homebrew Ruby: 2.6.3 => /home/d/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: 32-core 64-bit sandybridge
Clang: N/A
Git: 2.25.1 => /bin/git
Curl: 7.68.0 => /usr/bin/curl
Kernel: Linux 5.4.0-47-generic x86_64 GNU/Linux
OS: Ubuntu 20.04.1 LTS (focal)
Host glibc: 2.31
/usr/bin/gcc: 10.2.0
/usr/bin/ruby: 2.7.0
glibc: N/A
gcc: N/A
xorg: N/A

carlocab Dec 12, 2020

Looks like this might get fixed for you: Homebrew/homebrew-core#66763

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Homebrew

[m4] Please port gnulib fseeko.c to your platform! #263

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 3 comments 10 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

[m4] Please port gnulib fseeko.c to your platform! #263

Replies: 3 comments · 10 replies

hutson Dec 11, 2020 Author

hutson Dec 11, 2020 Author

hutson Dec 11, 2020 Author

hutson Dec 12, 2020 Author

Replies: 3 comments 10 replies

hutson
Dec 11, 2020
Author

hutson Dec 11, 2020
Author

hutson Dec 11, 2020
Author

hutson Dec 12, 2020
Author