-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature verification of 1.2.2 #1595
Comments
Any reason we aren't using the KEYS file in the documentation? |
Something along the lines of:
|
I ended up using the KEYS file. Didn't want to parse the release notes in the script that runs in our CI build.
|
I'm not sure how the other maintainers feel, but maybe a PR to the docs site? |
@FeynmanZhou This is a real case that we should move away from GPG signing. |
The GPG key changed in v1.2.2 release so we need to update the GPG key on ORAS documentation or considering removing the GPG key verification. We could discuss and make decision in the next community meeting. For ORAS maintainers, GPG key signing is cumbersome for automating the release process. For end users, it requires to trust a key from an individual maintainer as always. |
Agreed on GPG, but I think updating the docs would be helpful for now. |
Thanks @TerryHowe for the suggestion. I do agree with updating the doc to unblock the users of v1.2.2. |
What happened in your environment?
Signature verification is failing for 1.2.2 based off documentation Validating ORAS CLI Binaries.
It looks like there is a new public key KEYS because Shiwei Zhang was added.
The documentation needs to be updated? We should be using this new public key?
What did you expect to happen?
Signature verification will pass
How can we reproduce it?
Run below shell script
What is the version of your ORAS CLI?
1.2.2
What is your OS environment?
Amazon Linux 2023
Are you willing to submit PRs to fix it?
The text was updated successfully, but these errors were encountered: