Design of BigInt.toHex() and BigInt.toHexString()

[fewwwww]

For The Graph's graph-ts original implementation, BigInt.toHex() and BigInt.toHexString() behaves the same.

toHex(): string {
  return typeConversion.bigIntToHex(this);
}

toHexString(): string {
  return typeConversion.bigIntToHex(this);
}

However, in my thoughts toHex() should return a string that looks like deadbeef while toHexString() should return a string that looks like 0xdeadbeef.

So the implementation should be updated into:

toHex(): string {
  return typeConversion.bigIntToHex(this);
}

toHexString(): string {
  return "0x" + typeConversion.bigIntToHex(this);
}

Additionally, toHexString() is not tracked by The Graph's AssemblyScript API docs.

This issue is pending The Graph's opinion.

[fewwwww]

Discussed in the original graph-tooling/graph-ts repo (graphprotocol/graph-tooling#1389), a backward-compatible version is provided.

toHexString(prefix: string = ''): string {
  if (prefix !== '') {
    return prefix + typeConversion.bigIntToHex(this)
  }
  return typeConversion.bigIntToHex(this);
}