Skip to content
This repository has been archived by the owner on Nov 21, 2022. It is now read-only.

Slider Improvements #93

Open
3 tasks
djbusstop opened this issue Feb 15, 2020 · 0 comments
Open
3 tasks

Slider Improvements #93

djbusstop opened this issue Feb 15, 2020 · 0 comments

Comments

@djbusstop
Copy link
Contributor

djbusstop commented Feb 15, 2020

Objective
Fix the current slide implementation to work with floats when they come down the wire.

One change is on the condition when to style.

Another is the internal naming of the threshold for when to style
In the code, slider is the term used for the value of how much the user wants to block. This will make it more difficult to 1) understand what the value represents and 2) potentially change the way this value is set away from a slider. I think we want to change the way this level is understood throughout the code. It's REFACTORING

Change code to not refer to values of slider as slider, make generic "hide-level"

Description
change all use of slider when refering to the level

Skills

Tools

Time Estimation

Tasks

  • Step 1
  • Step 2
  • Step 3
@djbusstop djbusstop changed the title Change code to not refer to values of slider as slider, make generic "hide-level" Slider Improvements Mar 25, 2020
@djbusstop djbusstop added this to the 1.0.5 milestone Apr 3, 2020
@djbusstop djbusstop removed this from the 1.0.5 milestone May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant