Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility check #5362

Closed
Faithchidindu opened this issue Mar 31, 2023 · 2 comments
Closed

Accessibility check #5362

Faithchidindu opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@Faithchidindu
Copy link

oppia 2
oppia 1

The “stories you can play” text was not quite visible. The learner might struggle to read it. The text “stories you can play’ was given a white colour on a grey background so it did not pass the WCAG accessibility check.
It would be better if the text was given a black colour.
White text should be used on a dark background, dark text should be used on white background inorder to make the text easy to read

There is inconsistency in the UI theme. Some of the screens are in light mode while some are in dark mode. There is no uniformity. The user interface will look much better if the user is allowed to switch between light and dark themes. This creates a sense of uniformity, reliability and control

@seanlip seanlip transferred this issue from oppia/lessons-team Mar 18, 2024
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). bug End user-perceivable behaviors which are not desirable. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Mar 20, 2024
@ShubhadeepKarmakar
Copy link
Collaborator

I can't reproduce this issue/bug.
On my side:

Light mode

accessibility2

Dark mode

accessibility

I have checked the XML files, and everything is fine. Additionally, both 'topic_lessons_title.xml' and 'topic_lessons_story_summary.xml' use the same component color, namely 'component_color_shared_primary_text_color'. This means that if the text color for 'Stories You Can Play' is white, then the text color for 'Jaime's Adventures in the Arcade' would also be white.

@Faithchidindu I think some code changes have occurred on your side, which is why you are facing this issue.

@adhiamboperes
Copy link
Collaborator

Thanks @ShubhadeepKarmakar!

Given the time when this issue was filed, it is likely that this was encountered on an older version of the app, before we released full darkmode support. So I am closing this and adding in to 0.13 release blockers for verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

3 participants