-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Reorganize the Project Setup Documentation #5099
Comments
@seanlip, @MohitGupta121, could you please review my suggested Wiki updatates and let me know your thoughts? |
@adhiamboperes Thanks that's a very great issue. We have to complete this as High Priority as per my suggestions because now in the upcoming months, many new GSOC contributors are coming. So we have to solve and document all setup instructions properly. |
Hey @MohitGupta121, I will take the lead on this to set up the format that I have in mind. |
Okay, Thanks @adhiamboperes LGTM. These changes were very helpful to Windows users as most of them facing these issues. let's see what's @seanlip thoughts are to improve it more. |
All this sounds good to me. Let's please go ahead with it. Thanks @adhiamboperes! |
Hi @adhiamboperes. In your update be sure to include setting JDK 11 as the default compile JDK on Android Studio since the project has trouble compiling with any other JDK. |
…ntation (#5174) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fix #5073: Add instructions to the wiki for how to assign a reviewer. Fix #5062: Add wiki documentation for how to pick the emulator/android version when running Espresso tests. Fix #5099: Reorganize the Project Setup Documentation Fix part of #1723: ensure the onboarding flow leads into follow-up documentation: architecture overview, code style, submission guidelines, how to make UX changes, how to contribute large projects (which should tie into design documents), and best practices Fix part of #1723: Known issues that have come up in discussions ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Is your feature request related to a problem? Please describe.
Many new contributors run into issues setting up the project, especially on a Windows SDE. Having run tthrough the setup instructions myself, I noticed that while all the information needed to setup is present, a bit of reorganization would be useful to minimize skipping some important setup steps, which will in turn minimize the number of reported setup issues.
Some problems I noticed with the current instructions are:
bash setup.sh
command, missing out on important pre-push checks.Describe the solution you'd like
I do think that, pre full bazel migration, we should allow our contributors to get started with just gradle as this lowers the barriers to start contributing. Most of the starter issues for the foreseable future do not need interaction with Bazel.
Some changes we can make to improve the setup Wiki:
Then on each OSs page, we will have the complete OS specific setup instructions, numbered.
$JAVA_HOME
setup instructions to the Bazel set up section on each page, since they are only relevant there.google files check
file.Describe alternatives you've considered
This option is reactive rather than preventive.
We can still however have a section for this, especially for issues that cannot be prevented such as #4966 (comment).
Additional context
#5061
#4858
#4432
The text was updated successfully, but these errors were encountered: