Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill in cross JSON/classifier tests #449

Closed
BenHenning opened this issue Nov 20, 2019 · 2 comments
Closed

Fill in cross JSON/classifier tests #449

BenHenning opened this issue Nov 20, 2019 · 2 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Ensure there are tests to verify that we can parse and classify answers for all possible rules from JSON. This relates to #210 and #425.
@BenHenning BenHenning mentioned this issue Nov 20, 2019
Closed
@BenHenning
Copy link
Member Author

NB: this is only part of the necessary solution. We also need to make sure we're properly parsing all classifier inputs based on the backend spec. This should be done as part of #169.

@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Nov 20, 2019
@BenHenning BenHenning mentioned this issue Nov 20, 2019
Merged
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 16, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 16, 2023
@seanlip seanlip removed the Priority: Essential This work item must be completed for its milestone. label Jun 28, 2023
@BenHenning
Copy link
Member Author

We're probably not going to bother fixing this since we're eventually moving to proto, and JSON issues only affect developers using Gradle today.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seanlip @BenHenning @MohitGupta121 @Broppia