Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Administrator Controls #2728

Closed
rt4914 opened this issue Feb 15, 2021 · 13 comments
Closed

Issues with Administrator Controls #2728

rt4914 opened this issue Feb 15, 2021 · 13 comments
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 15, 2021

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Home`
  2. Open navigation drawer
  3. Click Options
  4. Open navigation drawer
  5. Click Admin Controls
  6. Click back
  7. Home screen is visible

Expected behavior
Whatever is last screen that should be opened in this case Options

Screenshots
untitled

Additional context
The current behavior might be correct. Waiting for confirmation from @mschanteltc

@rt4914 rt4914 added this to the Backlog milestone Feb 15, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 15, 2021

@mschanteltc PTAL and confirm if this is actually a bug or the current behaviour is correct.

@prayutsu
Copy link
Contributor

@rt4914 So, ideally we may want to return to the Options Fragment after pressing back from Admin Controls?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 15, 2021

@rt4914 So, ideally we may want to return to the Options Fragment after pressing back from Admin Controls?

@prayutsu Actually I am not sure.

@Arjupta
Copy link
Contributor

Arjupta commented Feb 15, 2021

@rt4914 I faced a similar bug.
Steps -

  • Enter admin profile
  • Open drawer
  • Click on Administrator Controls
  • Press Back
  • Open Drawer again

you will see both home and administer control to be highlighted in yellow like they both are selected

@prayutsu
Copy link
Contributor

@rt4914 I faced a similar bug.
Steps -

  • Enter admin profile
  • Open drawer
  • Click on Administrator Controls
  • Press Back
  • Open Drawer again

you will see both home and administer control to be highlighted in yellow like they both are selected

This is fixed in PR #2671.

@Arjupta
Copy link
Contributor

Arjupta commented Feb 15, 2021

@rt4914 I faced a similar bug.
Steps -

  • Enter admin profile
  • Open drawer
  • Click on Administrator Controls
  • Press Back
  • Open Drawer again

you will see both home and administer control to be highlighted in yellow like they both are selected

This is fixed in PR #2671.

This is latest fetch from develop
Screenshot_1613409618

@prayutsu
Copy link
Contributor

@Arjupta Actually the PR has not been merged yet, it has been approved by all the code owners and it will be merged soon.

@mschanteltc
Copy link

@mschanteltc PTAL and confirm if this is actually a bug or the current behaviour is correct.

The selected page should change in the background first before the menu slides back.

So from the Home Page, if I as a user tap the hamburger menu and select "Options," the page that is a layer below the side menu should change/fade to the Options page, and then the side menu hides. (mock)

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 17, 2021

The selected page should change in the background first before the menu slides back.

So from the Home Page, if I as a user tap the hamburger menu and select "Options," the page that is a layer below the side menu should change/fade to the Options page, and then the side menu hides. (mock)

@mschanteltc The issue that you have mentioned is different and I have filed a new issue for the same.
In this issue as mentioned in the description, its about the screens which should be shown under different scenarios.

@anandwana001
Copy link
Contributor

Is this blocked?

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 17, 2021

Is this blocked?

@anandwana001 Yes. Waiting for another reply from @mschanteltc

@mschanteltc
Copy link

Is this blocked?

@anandwana001 Yes. Waiting for another reply from @mschanteltc

Ah I see, yes this flow is correct. If the app is on a navigation drawer page that is not the Home Page, tapping the 'back' button navigates the learner to the Home Page.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 18, 2021

Okay. Thanks @mschanteltc
Closing this issues considering this is the expected behaviour of the app.

@rt4914 rt4914 closed this as completed Feb 18, 2021
@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2022
@BenHenning BenHenning changed the title Issues with Administrator Controls [BLOCKED] Issues with Administrator Controls Aug 8, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

No branches or pull requests

6 participants