Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable density-based APKs in Bazel #2276

Closed
BenHenning opened this issue Dec 16, 2020 · 1 comment
Closed

Enable density-based APKs in Bazel #2276

BenHenning opened this issue Dec 16, 2020 · 1 comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

This is derived from #2259. Bazel should have multiple builds with the following configurations:

  • Density-based production builds with proguard/appreduce enabled
  • Developer build with all density files included and no proguard/appreduce

This functionality will be new in Bazel since support for multi-apk builds needs to be turned off in Gradle.

@Broppia Broppia added dev_team Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. labels Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@BenHenning
Copy link
Member Author

We now have a very robust set of builds (with dev-specific features) for Bazel:

_FLAVOR_METADATA = {

There really isn't much advantage in going further than this since we are only uploading AABs now, and are probably going to remove APKs entirely in the future (since AABs allow Play Store and bundletool to generate density-specific APKs at installation time rather than requiring the Oppia team to manage multiple density-specific APKs).

With that in mind, I don't actually think we have any work to do here.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Development

No branches or pull requests

3 participants