Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why publish jobs (both dev and release) are taking very long #410

Open
benoit74 opened this issue Oct 8, 2024 · 2 comments
Open

Why publish jobs (both dev and release) are taking very long #410

benoit74 opened this issue Oct 8, 2024 · 2 comments
Labels
Milestone

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Oct 8, 2024

Since few weeks, publishing jobs for dev and release suddenly jumped from less than 10 minutes to more than 40 minutes

Image

This is not normal and should at least be investigated, and probably fixed.

@benoit74 benoit74 added the bug label Oct 8, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Oct 8, 2024

It looks like it is linked to the upgrade to 1.3.x line of browsertrix base image, which include an upgrade to Ubuntu Noble. At least a good track to follow.

@benoit74
Copy link
Collaborator Author

benoit74 commented Oct 8, 2024

It is the arm64 build (which is using buildx) which takes much much longer. Lot's of person on the Internet are experiencing problems around Noble and arm64, especially when not running on native hardware. Every topics I found always ended up with something circumventing the problem. I strongly suspect there is still a problem with Ubuntu Noble on arm64.

I tried to simply build again browsertrix-browser-base with buildx and the arm64 seems to never be finishing, I will update once it is done. It wasn't the case with previous Ubuntu used which I already built with buildx.

I see three alternatives:

  • open an issue upstream to fix Ubuntu Noble (good luck, I have no idea where I should open the issue, suggestions more than welcomed, and it is probably going to take very long)
  • split build job, on per platform, so that it can run natively. But is this possible with our Github action, can we build the two plateforms Docker images in two different jobs?
  • drop support for arm64: do we really need this image? I do not recall why we are doing this for a scraper, most (all?) other scraper seems to build only for amd64

@benoit74 benoit74 modified the milestones: 2.1.5, 2.2.0 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant