Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite already existing ZIM by default, stop immediately #399

Open
vitaly-zdanevich opened this issue Sep 26, 2024 · 4 comments
Open

Comments

@vitaly-zdanevich
Copy link

I restarted docker run -v /output:/output ghcr.io/openzim/zimit zimit --url https://flibusta.is --name flibusta - is it using previously saved zim?

@vitaly-zdanevich
Copy link
Author

On the second run I pressed Ctrl-C and it removed my zim from the first run!

@rgaudin
Copy link
Member

rgaudin commented Sep 26, 2024

Indeed the ZIM filename being constructed from the url and the current month, if you run twice the same exact command, it will overwrite your previous ZIM. And if you cancel during the second run, then you end up with nothing.

I think the reasonable way forward is a --overwrite option that if not present halts the run should the target ZIM file already exist.

@benoit74
Copy link
Collaborator

Good point!

@benoit74 benoit74 changed the title README: please add: would it be possible to continue? A website was unavailable for a couple of minutes. Do not overwrite already existing ZIM by default, stop immediately Sep 26, 2024
@benoit74
Copy link
Collaborator

And obviously this needs to be checked as soon as possible, at least before running the crawler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants