Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHS Medicines A to Z #1138

Closed
Popolechien opened this issue Aug 15, 2024 · 18 comments
Closed

NHS Medicines A to Z #1138

Popolechien opened this issue Aug 15, 2024 · 18 comments
Labels
Medical Medical related Content Zimit

Comments

@Popolechien
Copy link
Collaborator

Pretty much a copy of #323

@Popolechien Popolechien added Zimit Medical Medical related Content labels Aug 15, 2024
@RavanJAltaie
Copy link
Contributor

Recipe created
https://farm.openzim.org/recipes/nhs.uk-medicines_en_all
I'll update the library once ready

@RavanJAltaie
Copy link
Contributor

File is ready at the library
https://library.kiwix.org/viewer#nhs.uk-medicines_en_all_2024-08

@kelson42 kelson42 reopened this Aug 26, 2024
@kelson42
Copy link
Collaborator

kelson42 commented Aug 26, 2024

Not ready, all top bar links are directly pointing to the online Web site.

Can we do something about this recurring cookie banner?

@Popolechien
Copy link
Collaborator Author

@kelson42 That's because we only scraped a subset of the top-level site I believe.
Either way, I suspect this fits what I described at openzim/zimit#374

@RavanJAltaie
Copy link
Contributor

@kelson42 we are scrapping only the medicine part, not all the website.
The tabs are for other fields.

@benoit74
Copy link
Contributor

benoit74 commented Sep 2, 2024

Any reason to not hide the top bar then, if it only contains links to non-working parts, I see little reason to keep it?

Only concern it that we have no more button/link to "home" if we remove the top links, but most readers have one, isn't it?

And since we also scrape the "conditions" part in a different ZIM, do we really need to have two distinct ZIMs ? The medicine part seems to be only few 10s of MB, not something very concerning to justify being put aside, or do I miss something?

@Popolechien
Copy link
Collaborator Author

While it may make sense for the NHS website to have both conditions and medicines on a single website, I would argue that the way we present content makes it more approchable if it is one zim = one type of content.

Agree on removing the top bar, though we would lose the NHS branding and that is a bit of a bummer; but I see two home buttons (which don't work as they point to nhs.uk) - the NHS logo and the Home hyperlink.
Screenshot 2024-09-02 at 10 01 54

@benoit74
Copy link
Contributor

benoit74 commented Sep 2, 2024

OK then let's go for two ZIMS (but ZIM names will have to be fixed, see #1153).

Not sure it is feasible, but what you should request me to do (from my own PoV, I'm clearly a silly person ^^) is to remove following zones in red:

Screenshot 2024-09-02 at 11 52 40

image

@RavanJAltaie
Copy link
Contributor

@benoit74 clearly you can do this for sure (Deleting the upper bar)

@benoit74
Copy link
Contributor

Custom CSS created, recipe updated to publish to dev with this custom CSS and requested, let's see.

@benoit74
Copy link
Contributor

clearly you can do this for sure (Deleting the upper bar)

I just realize this is very ambiguous. I proposed to delete far more than the upper bar. Current CSS deletes everything marked in red in my screenshot.

@Popolechien
Copy link
Collaborator Author

LGTM ¯_(ツ)_/¯

@Popolechien
Copy link
Collaborator Author

the cookie banner is still here but other than that this looks good to go
Screenshot 2024-09-17 at 15 23 00
Or was your custom CSS also supposed to take care of the banner?

@benoit74
Copy link
Contributor

I never realized there is a cookie banner. I'm a bit sad you did not insisted on this before. It is straightforward to remove for me. CSS updated and recipe launched again.

@RavanJAltaie
Copy link
Contributor

@benoit74 the file looks perfect, I've pushed to library.

@RavanJAltaie
Copy link
Contributor

File is ready at the library
https://library.kiwix.org/viewer#nhs.uk-conditions_en_all_2024-09

@benoit74
Copy link
Contributor

Your link is about conditions not medicines, and it is not updated with the proper CSS update to hide cookie banner and irelevant links

@benoit74 benoit74 reopened this Sep 19, 2024
@RavanJAltaie RavanJAltaie added the In Progress Issues waiting response to be solved label Sep 19, 2024
@benoit74
Copy link
Contributor

File is now really ready in the library: https://library.kiwix.org/viewer#nhs.uk_en_medicines_2024-09

@benoit74 benoit74 removed the In Progress Issues waiting response to be solved label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medical Medical related Content Zimit
Projects
None yet
Development

No branches or pull requests

4 participants