Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pywikiapi: why + update #162

Open
benoit74 opened this issue Mar 5, 2024 · 2 comments
Open

pywikiapi: why + update #162

benoit74 opened this issue Mar 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Mar 5, 2024

We should:

  • document why we are using pywikiapi instead of pywikibot (there is probably a good reason but it seems it is about to get lost)
  • use upstream pywikiapi package (PyPi) instead of custom repo, now that our changes have been merged and we have write access to the upstream repo: Enhancements from openZIM devs nyurik/pywikiapi#3
@benoit74 benoit74 added the enhancement New feature or request label Mar 5, 2024
@rgaudin
Copy link
Member

rgaudin commented Mar 5, 2024

Git commit introducing it doesn't mention this.

I don't recall which options were considered and what were the reasons but I'd guess it's because our usage of the API is very limited and because pywikiapi is just a thin wrapper handling pagination in our case.

Feel free to reconsider.

@benoit74
Copy link
Collaborator Author

@kelson42 mentioned on slack we might want to consider Pywikibot instead of Pywikiapi

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants