Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox on chopin.lib.uchicago.edu scores are not working #409

Open
benoit74 opened this issue Oct 11, 2024 · 1 comment
Open

Combobox on chopin.lib.uchicago.edu scores are not working #409

benoit74 opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@benoit74
Copy link
Collaborator

ZIM request: openzim/zim-requests#604

Problem: see openzim/zim-requests#604 (comment)

We have a form which target `` URL which is not rewritten because warc2zim consider this URL is external. This is only partially true because the form never calls this URL without a query parameter, and with the query parameter the URL become internal, i.e. proper ressource is insise the ZIM ... too bad.

Should we detect that <form> URL is internal because we have a least one URL with a query parameter matching the form URL? Clearly a bit nasty and would not work in 100% of the cases, but would probably be ok for at least a majority... to be investagated further.

@benoit74
Copy link
Collaborator Author

Note that on this website we are lucky to only have a warc2zim issue because we have prev / next links which allowed the crawler to properly fetch all required pages. But from a general PoV, we have also an issue with browsertrix crawler which is not capable to crawl combobox urls automatically. I've just opened webrecorder/browsertrix-crawler#702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant