Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags #181

Open
Tracked by #21
benoit74 opened this issue Aug 14, 2023 · 4 comments
Open
Tracked by #21

Upgrade python-scraperlib to 3.x, including CLI support for description / long_description flags #181

benoit74 opened this issue Aug 14, 2023 · 4 comments
Labels
enhancement good first issue
Milestone
v1.1.0

Comments

@benoit74
Copy link
Collaborator

See openzim/overview#21
@benoit74 benoit74 added this to the v1.1.0 milestone Aug 14, 2023
@benoit74 benoit74 mentioned this issue Aug 14, 2023
Open
11 tasks
@joe-rabbit
Copy link

The changes to be made in scraper.py , entrypoint.py. Kindly assign this task to me

@joe-rabbit
Copy link

I have made the changes by adding a function that handles the checks the description length instead of the if else in the return in
get_zim_info function.

@joe-rabbit
Copy link

also favicon in the make zim file is now illustrations , not longer favicon

@joe-rabbit joe-rabbit mentioned this issue Jan 4, 2024
Closed
@joe-rabbit
Copy link

#183 kindly check this

@kelson42 kelson42 pinned this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

support_description_long_description joe-rabbit/openedx
2 participants
@benoit74 @joe-rabbit