-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old (v0) titleindex (title pointer list) #800
Comments
Given the discussions on the complexities of supporting X/lisiting/titleOrdered/v1, and in particular on the fallbacks that are necessary if we don't find data in that listing (see kiwix/kiwix-js#597 and kiwix/kiwix-js#708), I would just urge a very cautious approach towards deprecating the |
@Jaifroid I don't understand your comment: do we have any problem with the current ZIM spec and/or implementation on any part of our software portfolio? |
@kelson42 No, but this is a low-level potentially breaking change, and because we still use a custom JS backend in Kiwix JS, I would like to be sure to have enough time to make any low-level adjustments if needed. |
@Jaifroid It's not breaking anything regarding current ZIM specification... if implementation of reader is OK. You are IMO the only one in position to check if kiwix JS implementation is OK and such a ticket won't break anything there. We need to be cautious with FUD effect. |
@Jaifroid Should I assume all good on your side and we could consider us ready for this issue version 10 of the libzim? |
@kelson42 Apologies, I'm on holiday so not responding as fast as normally. I can't say for sure that there would be no consequences without a ZIM to test. From memory, we use the |
At the time of "removal" of namespaces, the "old" titleindex has been superseeded by the new "titleindex which is available as a normal item via X/listing/titleordered/v1.
We should considering removing the old pointer list at . This should not be used anymore because deprecated 2 years ago and use storage "for nothing".
The move is easy just put
00
in the header in place on the title pointer list pointer and stop writing the old version of this pointer list.But before doing that we should better check wit third party ZIM readers to verify that they don't use anymore:
The text was updated successfully, but these errors were encountered: