Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CL-Signature changes that were applied in the main branch to the anoncreds-rs branch #2411

Closed
usingtechnology opened this issue Aug 10, 2023 · 3 comments
Assignees
Labels
AnonCreds Ledger Agnostic AnonCreds

Comments

@usingtechnology
Copy link
Contributor

usingtechnology commented Aug 10, 2023

Change in scope for this task. It is now just to apply the changes from #2302 into the anoncreds-rs branch. The changes include new features/improvements in CL Signatures, such as not needed the tails file for issuing and revoking credentials. That will reduce the need for keeping local copies of tails files after creation/publishing.

We'll add plan/set of tasks for merging the anoncreds-rs branch into main vs. the other way round. Or we will do it the other way round. TBD.

Old scope:

Sub-task for #2297.
anoncreds-rs branch is very out of date with main. We need to get this synced before taking on more new code.

Will need to coordinate work between @dbluhm and @usingtechnology - the work that @andrewwhitehead did around credx impacts changes to the Base ledger and will be the trickiest logic to merge in.

@usingtechnology
Copy link
Contributor Author

Just did a simple merge main onto anoncreds-rs to look at impact. Most merge conflicts are straightforward (ex. library version updates, text in readmes). There are a few areas that will require some deep knowledge about why code as changed...

  • askar/profile
  • core/conductor
  • ledger/base
  • revocation/manager
  • revocation/models/issuer_cred_rev_record

All in all I don't think it's a significant amount of work, but certainly not an automatic effort.

@swcurran
Copy link
Contributor

git process:

  • Merge main into the anoncreds branch
  • Resolve differences -- which are mainly to do with Andrew's changes related to updates to CredX/CL-Signatures

@dbluhm will do after 2409.

@andrewwhitehead -- need to get anoncreds-rs released first, with the latest CL-Signatures library embedded. Need to confirm with other AnonCreds devs if they have anything else.

@swcurran swcurran changed the title Merge main into anoncreds-rs Apply CL-Signature changes that were applied in the main branch to the anoncreds-rs branch Oct 20, 2023
@swcurran
Copy link
Contributor

swcurran commented Dec 4, 2023

This has been done in the work @ianco has been doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AnonCreds Ledger Agnostic AnonCreds
Projects
None yet
Development

No branches or pull requests

3 participants