-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: add crypto implementations as optional import #66
Comments
Since we are planning to split it up in multiple packages, we could create two implementations that can be used and can be used on demand. Then everyone should be happy |
That's good idea :) |
I think providing some default crypto can be very nice. Deciding which algorithms to support might get a bit more complex. I suggest the following: packages
Algorithms
But just to be clear, these should match an interface provided by the core library and users can provide their own cryptography. |
@berendsliedrecht yeah, I would go with the default ones that are supported natively by Node or the browser. For me the EC based ones would be enough since RSA is not the way to go today. |
Agreed. Supporting React Native is also good idea. (Might need to check the Expo) |
I think supporting all the native ones is a good goal, but quite a bit. Also, it is not consistent between platforms. We could diverge them, but I think it would provide a nicer experience for all the packages to have the same functionality and keep it limited at a start. Especially with key management, users will likely already have some mechanism for that, so I don't expect heavy usage of these packages. |
I would prefer to start with a "mvp" approach, giving people an implementation for EC for Browser, Node and React Native, and for hash maybe SHA 256. Of course we will not limit it to this, but having this generic interface allows everyone to append one more crypto implementation. |
Which way do you prefer?
|
I am a fan of native ones because there is less third party dependency. We already have them implemented in the example so it's not big deal to finish this task (for now). In case we see problems with the implementation we can quickly add noble-curve. |
Okay Let's try native one first :) |
Native has my preference as well. That way it would also be easier to add potential support for |
I'll work on the nodejs and browser first :) |
Closing this since it got implemented in #106 |
To make the usage easier for developers, I would suggest also to publish an implementation for the signet and verifier functions like key generation, hashing etc.
I would like to include it in the src folder and not an example folder so a developer can easily import and use it.
We are not forcing someone to use it, but we offer a challenged implementation that is ready to be used in the browser or in nodejs.
The text was updated successfully, but these errors were encountered: