From f5e6206b940dffaa660968b6270e35c7ad698172 Mon Sep 17 00:00:00 2001 From: Mohammad Haghighipanah Date: Tue, 15 Oct 2024 14:27:27 -0700 Subject: [PATCH 1/3] fixed CVS-149659 coverity issue --- .../transformations/dynamic_quantize_fully_connected.cpp | 3 ++- .../plugin/transformations/increase_position_ids_precision.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp b/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp index 68328160a98f82..52857838264a49 100644 --- a/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp +++ b/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp @@ -17,7 +17,8 @@ namespace ov { namespace intel_gpu { -DynamicQuantizeFullyConnected::DynamicQuantizeFullyConnected(uint64_t group_size) { +DynamicQuantizeFullyConnected::DynamicQuantizeFullyConnected(uint64_t group_size) + : ov::pass::MatcherPass() { // Explicitly call the base class constructor{ GPU_DEBUG_GET_INSTANCE(debug_config); using namespace ov::pass::pattern; diff --git a/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp b/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp index a79a339a501798..224f5d486d1cbd 100644 --- a/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp +++ b/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp @@ -47,7 +47,7 @@ IncreasePositionIdsPrecision::IncreasePositionIdsPrecision() { auto rope = wrap_type({any_input(), rope_cos_input, rope_sin_input}); - ov::matcher_pass_callback callback = [OV_CAPTURE_CPY_AND_THIS](ov::pass::pattern::Matcher& m) { + ov::matcher_pass_callback callback = [=, this](ov::pass::pattern::Matcher& m) { const auto& pattern_map = m.get_pattern_value_map(); auto matmul_node = std::dynamic_pointer_cast(pattern_map.at(gemm_or_matmul).get_node_shared_ptr()); From 5f536734ba3361e33b1ebba723040982418ae89e Mon Sep 17 00:00:00 2001 From: Mohammad Haghighipanah Date: Thu, 14 Nov 2024 09:45:31 -0800 Subject: [PATCH 2/3] removed bracket in comment --- .../plugin/transformations/dynamic_quantize_fully_connected.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp b/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp index 52857838264a49..30267020bb29c2 100644 --- a/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp +++ b/src/plugins/intel_gpu/src/plugin/transformations/dynamic_quantize_fully_connected.cpp @@ -18,7 +18,7 @@ namespace ov { namespace intel_gpu { DynamicQuantizeFullyConnected::DynamicQuantizeFullyConnected(uint64_t group_size) - : ov::pass::MatcherPass() { // Explicitly call the base class constructor{ + : ov::pass::MatcherPass() { // Explicitly call the base class constructor GPU_DEBUG_GET_INSTANCE(debug_config); using namespace ov::pass::pattern; From 4078f44f2c5d389367db7901fb619eba2c578439 Mon Sep 17 00:00:00 2001 From: Mohammad Haghighipanah Date: Thu, 21 Nov 2024 09:09:02 -0800 Subject: [PATCH 3/3] reverting the changes --- .../plugin/transformations/increase_position_ids_precision.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp b/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp index 224f5d486d1cbd..a79a339a501798 100644 --- a/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp +++ b/src/plugins/intel_gpu/src/plugin/transformations/increase_position_ids_precision.cpp @@ -47,7 +47,7 @@ IncreasePositionIdsPrecision::IncreasePositionIdsPrecision() { auto rope = wrap_type({any_input(), rope_cos_input, rope_sin_input}); - ov::matcher_pass_callback callback = [=, this](ov::pass::pattern::Matcher& m) { + ov::matcher_pass_callback callback = [OV_CAPTURE_CPY_AND_THIS](ov::pass::pattern::Matcher& m) { const auto& pattern_map = m.get_pattern_value_map(); auto matmul_node = std::dynamic_pointer_cast(pattern_map.at(gemm_or_matmul).get_node_shared_ptr());