[CPU] Enable and address google-* clang-tidy remarks #28537
+6,121
−3,254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aobolensk
changed the title
aobolensk
force-pushed
the
clang-format-google
branch
11 times, most recently
from
9142aeb to
dd946a0
Compare
Comment on lines
+47
to
+51
| -google-default-arguments, | ||
| -google-explicit-constructor, | ||
| -google-readability-casting, |
There was a problem hiding this comment.
Please add them to the comment to the list of checks we want to enable later
|
@dmitry-gorokhov Could you please take a look. |
except google-explicit-constructor
aobolensk
force-pushed
the
clang-format-google
branch
from
dd946a0 to
98b8e04
Compare
aobolensk
force-pushed
the
clang-format-google
branch
from
7eef6d6 to
869c004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
google-*checks in clang-tidy for CPU plugin implementationgoogle-explicit-constructorfromgoogle-*scope, because it is error prone,google-default-arguments- to be able to have default function arguments in virtual functions,google-readability-casting- potentially may be enabled laterTickets: