[CPU][TESTS] Remove sse4 instances from oneDNN related tests #28527
+14
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorDuplensky
force-pushed
the
remove_sse_func_test_instances
branch
from
40c491c to
a3af54f
Compare
| @@ -159,7 +156,6 @@ namespace ConvolutionConcat { | |||
| /* ============= Convolution (2D) ============= */ | |||
| const std::vector<CPUSpecificParams> CPUParams2D = { | |||
| conv_ref_2D, | |||
There was a problem hiding this comment.
What about ref? Don't see big value in explicit testing on out side (and given ref conv is tremendously slow it might noticable affect scope timings).
There was a problem hiding this comment.
let's remove it as well
|
General question: what will happen if we will run Convolution tests on SSE platform? Won't the scope be empty at all after these changes? |
Only shared tests will be executed in this case, which is fine I guess. |
Seems to not worth to verify them considering how slow they are
EgorDuplensky
force-pushed
the
remove_sse_func_test_instances
branch
from
a3af54f to
74fc14c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to not worth to verify them considering how slow they are