Fixes dynamic shapes #27776
Fixes dynamic shapes #27776
Conversation
Signed-off-by: Skrebkov, Artemy <[email protected]>
Signed-off-by: Skrebkov, Artemy <[email protected]>
Signed-off-by: Skrebkov, Artemy <[email protected]>
ArtemySkrebkov
force-pushed
the
fixes-dynamic-shapes
branch
from
05e06bb to
a1369c4
Compare
Signed-off-by: Skrebkov, Artemy <[email protected]>
Signed-off-by: Skrebkov, Artemy <[email protected]>
| @@ -56,7 +56,7 @@ void check_level_zero_attributes_match(const IODescriptor& ioDescriptor, const A | |||
|
|
|||
| for (size_t index = 0; index < ovDimensions.size(); ++index) { | |||
| OPENVINO_ASSERT( | |||
| ioDescriptor.shapeFromCompiler.is_dynamic() || ovDimensions[index] == zeDescriptor.info.dims[index], | |||
| ovDimensions[index] == zeDescriptor.info.dims[index], | |||
There was a problem hiding this comment.
shapeFromCompiler is serialized using upper bounds always.
Signed-off-by: Skrebkov, Artemy <[email protected]>
|
@StefaniaHergane @razvanapetroaie May I ask you to review the PR, please? The results from VPUX repo looks good besides a single network. I will explain the reason on the failure in the corresponding PR. Do you think we can merge this PR if it does not break anything in OV PR checker? |
|
This PR will be closed in a week because of 2 weeks of no activity. |
Signed-off-by: Skrebkov, Artemy <[email protected]>
ArtemySkrebkov
requested review from
ilya-lavrenov
and removed request for
a team
Co-authored-by: Pawel Raasz <[email protected]>
Co-authored-by: Pawel Raasz <[email protected]>
Signed-off-by: Skrebkov, Artemy <[email protected]>
Signed-off-by: Skrebkov, Artemy <[email protected]>
|
Thank you for taking time to review the PR! |
There was a problem hiding this comment.
Just a question here. We have also a check related to dynamism in the check_tensor function. Do you need to change that one as well?
src/plugins/intel_npu/src/compiler_adapter/src/ze_graph_ext_wrappers.cpp
Show resolved
Hide resolved
The check looks just fine to me, I haven't seen it failing. However, I see another issue at the moment, reached out to you in Teams. |
### Details: * Aligns fixes in dynamic shape serializing with intel-innersource/applications.ai.vpu-accelerators.vpux-plugin#14490 * Fix parsing of shapes for SIT ### Tickets: - E147314 - E147315 --------- Signed-off-by: Skrebkov, Artemy <[email protected]> Co-authored-by: Pawel Raasz <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Details:
Tickets: