Memory leak caused by the ConnectionsClient

[ekigamba]

I have tested this on two devices (Samsung table Android 7.0 and itel mobile phone Android 6.0) where one is advertising and the other is discovering. The leak seems to happen on both devices irrespective of which device disconnects from the endpoint first. The code for the Nearby Connections API seems to not be open-source or available through the usual channels and I could not pinpoint the issue further.

This is what my cleanup code looks like

        view.dismissAllDialogs();
        view.enableSendReceiveButtons(true);

        interactor.stopAdvertising();
        interactor.stopDiscovering();

        if (getCurrentPeerDevice() != null) {
            interactor.disconnectFromEndpoint(getCurrentPeerDevice().getEndpointId());
        }

        setCurrentDevice(null);

The code does call the disconnectFromEndpoint which calls the single instance of the connectionsClient

https://issuetracker.google.com/issues/129429944

The onConnectionBroken or onConnectionUnknownErroror onDisconnected seem to be called after exiting the activity and after the cleanup code has been called

[ekigamba]

This might need to be tested with the itel device which is pretty slow. It is not easily replicable using fast devices