-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary and count causes performance issues on large datasets #37
Comments
Nice find!
Alternatively "include_fields" might be more maintainable than "simple", so
there isn't need to come up with more parameters for different partial
response combinations.
Are you able to make a pull request for something like this?
…On Sun, 20 Nov 2022, 17:34 Mark Brough, ***@***.***> wrote:
With very large datasets (e.g. 13m rows), summary and count appear to
significantly slow down the response:
https://github.com/openspending/babbage/blob/9416105fd18dda13b06aaaeec0ce7abdd13d8453/babbage/cube.py#L89-L96
Without generating summary and count, it's 2-3 times faster to return the
response.
It would be useful to make returning these properties optional. E.g. by
adding an optional &simple parameter to the request.
—
Reply to this email directly, view it on GitHub
<#37>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZSGLYZXXXBTGGNQCQEQ3WJJAHTANCNFSM6AAAAAASF4W6YY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Maybe |
Because I need this for something quickly, I implemented it already the way I described above - but happy to hear your feedback on the above and then I can adjust: |
With very large datasets (e.g. 13m rows),
summary
andcount
appear to significantly slow down the response:babbage/babbage/cube.py
Lines 89 to 96 in 9416105
Without generating
summary
andcount
, it's 2-3 times faster to return the response.It would be useful to make returning these properties optional. E.g. by adding an optional
&simple
parameter to the request.The text was updated successfully, but these errors were encountered: