Welcome! We are glad that you want to contribute to our project!
As you get started, you are in the best position to give us feedback on areas of our project that we need help with including:
- Problems found during setting up a new developer environment
- Gaps in our Quickstart Guide or documentation
- Bugs in our automation scripts
If anything doesn't make sense, or doesn't work when you run it, please open a bug report and let us know!
We welcome many different types of contributions including:
- New features
- Builds, CI/CD
- Bug fixes
- Documentation
- Issue Triage
- Answering questions on GitHub Discussions
- Communications / Social Media / Blog Posts
- Release management
Not everything happens through a GitHub pull request. Please contact us and let's discuss how we can work together.
We have good first issues for new contributors and help wanted issues suitable for any contributor. good first issue has extra information to help you make your first contribution. help wanted are issues suitable for someone who isn't a core maintainer and is good to move onto after your first pull request.
Sometimes there won’t be any issues with these labels. That’s ok! There is likely still something for you to work on. If you want to contribute but you don’t know where to start or can't find a suitable issue, you can ask for an issue to work on the Discussions.
Once you see an issue that you'd like to work on, please post a comment saying that you want to work on it. Something like "I want to work on this" is fine.
The best way to reach us with a question when contributing is to ask on:
- The original github issue
If you want to make a non-trivial change, such as a new feature or a bug fix to break exiting behavior, please discuss it first with maintainers on a issue, discussion or a proposal PR you send.
When your PR becomes ready for review, it isn't a draft and all tests pass, we will start a review process. Reviewers are selected automatically, so you don't care about them.
If your change is approved by us, we will merge it immediately and it will be shipped on the next monthly release.
When there has been no activity for 30 days, the stale bot will label it stale. And if there is no activity for another 7 days, it will be closed.
Our recommended environment is Ubuntu 22.04. Because following steps modify your system globally, we suggest preparing a dedicated physical or virtual machine.
-
Download the repository.
git clone [email protected]:topolvm/topolvm.git
-
Install the required tools.
cd topolvm make setup -
Make changes you wish.
-
Test your changes.
# for unit test and lint make test # for end-to-end test cd test/e2e make start-lvmd make test
Licensing is important to open source projects. It provides some assurances that the software will continue to be available based under the terms that the author(s) desired. We require that contributors sign off on commits submitted to our project's repositories. The Developer Certificate of Origin (DCO) is a way to certify that you wrote and have the right to contribute the code you are submitting to the project.
You sign-off by adding the following to your commit messages. Your sign-off must match the git user and email associated with the commit.
This is my commit message
Signed-off-by: Your Name <[email protected]>
Git has a -s command line option to do this automatically:
git commit -s -m 'This is my commit message'
If you forgot to do this and have not yet pushed your changes to the remote repository, you can amend your commit with the sign-off by running
git commit --amend -s
When you submit your pull request, or you push new commits to it, our automated systems will run some checks on your new code. We require that your pull request passes these checks, but we also have more criteria than just that before we can accept and merge it. We recommend that you check the following things locally before you submit your code:
- If your code has breaking changes, please update related documents.
- If you add a new feature, please add unit or end-to-end tests for it.