-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FILLNULL command in PPL (#3032) #3075
base: main
Are you sure you want to change the base?
Add FILLNULL command in PPL (#3032) #3075
Conversation
* Add FILLNULL command in PPL Signed-off-by: Norman Jordan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Could you add some integration tests? They live here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add an ExplainTest to validate that you get an Eval physical plan when using FILLNULL.
Signed-off-by: Norman Jordan <[email protected]>
@MaxKsyunz I have added some integration tests. |
@jduo I have added an explain test. |
os> source=accounts | fields email, host | fillnull using email = '<not found>', host = '<no host>' ; | ||
fetched rows / total rows = 4/4 | ||
+-----------------------+------------+ | ||
| email | host | | ||
|-----------------------+------------| | ||
| [email protected] | pyrami.com | | ||
| [email protected] | netagy.com | | ||
| <not found> | | | ||
| [email protected] | boink.com | | ||
+-----------------------+------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing <no host>
from the right column, right? Same for the table above, it looks like one <not found>
is missing?
os> source=accounts | fields email, host | fillnull using email = '<not found>', host = '<no host>' ; | |
fetched rows / total rows = 4/4 | |
+-----------------------+------------+ | |
| email | host | | |
|-----------------------+------------| | |
| [email protected] | pyrami.com | | |
| [email protected] | netagy.com | | |
| <not found> | | | |
| [email protected] | boink.com | | |
+-----------------------+------------+ | |
os> source=accounts | fields email, host | fillnull using email = '<not found>', host = '<no host>' ; | |
fetched rows / total rows = 4/4 | |
+-----------------------+------------+ | |
| email | host | | |
|-----------------------+------------| | |
| [email protected] | pyrami.com | | |
| [email protected] | netagy.com | | |
| <not found> | <no host> | | |
| [email protected] | boink.com | | |
+-----------------------+------------+ |
Description
Adds the FILLNULL command for PPL. FILLNULL will replace NULL values in specified fields.
Related Issues
Resolves #3032
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.