Add FILLNULL command in PPL (#3032) #3075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add FILLNULL command in PPL Signed-off-by: Norman Jordan <[email protected]>
normanj-bitquill
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
YANG-DB
previously approved these changes
Oct 18, 2024
jduo
suggested changes
Oct 18, 2024
Signed-off-by: Norman Jordan <[email protected]>
|
@MaxKsyunz I have added some integration tests. |
|
@jduo I have added an explain test. |
currantw
reviewed
Oct 24, 2024
Comment on lines
+54
to
+63
| os> source=accounts | fields email, host | fillnull using email = '<not found>', host = '<no host>' ; | ||
| fetched rows / total rows = 4/4 | ||
| +-----------------------+------------+ | ||
| | email | host | | ||
| |-----------------------+------------| | ||
| | [email protected] | pyrami.com | | ||
| | [email protected] | netagy.com | | ||
| | <not found> | | | ||
| | [email protected] | boink.com | | ||
| +-----------------------+------------+ |
There was a problem hiding this comment.
This is missing <no host> from the right column, right? Same for the table above, it looks like one <not found> is missing?
Suggested change
| os> source=accounts | fields email, host | fillnull using email = '<not found>', host = '<no host>' ; | |
| fetched rows / total rows = 4/4 | |
| +-----------------------+------------+ | |
| | email | host | | |
| |-----------------------+------------| | |
| | [email protected] | pyrami.com | | |
| | [email protected] | netagy.com | | |
| | <not found> | | | |
| | [email protected] | boink.com | | |
| +-----------------------+------------+ | |
| os> source=accounts | fields email, host | fillnull using email = '<not found>', host = '<no host>' ; | |
| fetched rows / total rows = 4/4 | |
| +-----------------------+------------+ | |
| | email | host | | |
| |-----------------------+------------| | |
| | [email protected] | pyrami.com | | |
| | [email protected] | netagy.com | | |
| | <not found> | <no host> | | |
| | [email protected] | boink.com | | |
| +-----------------------+------------+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the FILLNULL command for PPL. FILLNULL will replace NULL values in specified fields.
Related Issues
Resolves #3032
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.