-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][data-prepper] Chart values should not have a default pipeline defined #624
Comments
[Triage] |
We could comment the pipeline, but that would leave an empty config and prevent the prepper from starting at all after a |
See the pull requewst implementing my proposal. This is a cleaner way to enable demo pipeline. |
Thanks @janhoy |
Describe the bug
The default values file has a demo pipeine defined. Even if you in your own values file define a
my-pipeline
, the demosimple-sample-pipeline
will be deployed alongside it.To Reproduce
Steps to reproduce the behavior:
myvalues.yaml
file with apipelineConfig.config.my-pipeline
defined-f myvalues.yaml
foo-data-prepper-pipeline
secret - it contains both pipelines.Expected behavior
You'd expect that the pipeline you configure is the only one installed.
You can achieve a blank slate today by using the
existsingSecret
property, but for simple pipelines the convenience of defining it in values file should achieve the same.Chart Name
data-prepper
Screenshots
Host/Environment (please complete the following information):
Additional context
Proposed fix is to ship chart without a configured pipeline. Alternatively use a
noop
pipeline that does nothing, to make the prepper not crash. Instead, ship anexamples/
folder and move thesimple-sample-pipeline
example to a separate values file in that folder so users can dohelm install myprepper opensearch/data-prepper -f example-values.yaml
to test.The text was updated successfully, but these errors were encountered: