Adding @SergK to please take a look as well.
@getsaurabh02

Thanks @janhoy I like the approach to use --set pipelineConfig.demoPipeline=true, can you please fix the failing the CI tests?

@janhoy I've pushed out the updates to hopefully get the linter passing.

FYI, by default this would be a breaking change for anybody upgrading. Specifically because the default stance of the values.yaml assumes neither the demopipeline or user inputted pipeline has been enabled.

My recommendation is we keep existing behaviours and have the demoPipeline enabled by default.

This is why the CI Pipelines are failing as well:

Error: INSTALLATION FAILED: execution error at (data-prepper/templates/deployment.yaml:98:27): A valid pipeline configuration is required! Please set one of:
pipelineConfig.existingSecret - for your custom pipeline secret
pipelineConfig.enabled - for inline configuration in values.yaml or
pipelineConfig.demoPipeline=true - for a sample demo pipeline using random source and stdout sink.

My recommendation is we keep existing behaviours and have the demoPipeline enabled by default.

Yes, it was breaking change. I modified the behavior so that the demo pipeline is installed automatically only when no pipeline-secret or inline pipeline is enabled. The demoPipeline value defaults to "" which causes this auto mode, but it can still be overridden with true to explicitly install demo pipline (in which case any other configured pipeline will NOT be installed, or false in which case helm install will fail if no other pipeline is configured.

I do not see a benefit in preserving the possibility of ADDING a demo pipeline to an existing one, it would also be quite complicated. The "simple-sample-pipeline" is commented in values.yaml, so users can achieve this by modifying their own pipeline.