Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ml-commons plugin introducing a new optional field "config" in MLTooSpec #878

Closed
jngz-es opened this issue Sep 23, 2024 · 1 comment · Fixed by #899
Closed
Assignees
Labels
enhancement New feature or request v2.18.0 Issues targeting release v2.18.0

Comments

@jngz-es
Copy link

jngz-es commented Sep 23, 2024

Is your feature request related to a problem?

Ml-commons is introducing a new field config in MLToolSpec as showed in the pr opensearch-project/ml-commons#2977. With the change, we allow cx to configure some static parameters for tools that stay unchanged/persist during the tool execution. It will fix a couple of bugs mentioned in the pr.

What solution would you like?

The pr opensearch-project/ml-commons#2977.

What alternatives have you considered?

N/A.

Do you have any additional context?

It's an optional field.

@jngz-es jngz-es added enhancement New feature or request untriaged labels Sep 23, 2024
@dbwiddis dbwiddis added good first issue Good for newcomers v2.18.0 Issues targeting release v2.18.0 and removed untriaged labels Sep 23, 2024
@dbwiddis
Copy link
Member

This should be a simple change to the ToolStep class adding the new optional parameter.

@dbwiddis dbwiddis self-assigned this Oct 3, 2024
@dbwiddis dbwiddis removed the good first issue Good for newcomers label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.18.0 Issues targeting release v2.18.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants