Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update to Apache Lucene 10 for 3.0.0 #11415

Open
reta opened this issue Nov 30, 2023 · 6 comments · May be fixed by #16366
Open

[FEATURE] Update to Apache Lucene 10 for 3.0.0 #11415

reta opened this issue Nov 30, 2023 · 6 comments · May be fixed by #16366
Assignees
@reta
Labels
dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0

Comments

@reta
Copy link
Collaborator

reta commented Nov 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The Apache Lucene 10 is released [1]!:

[1] https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0

Notable features:

Describe the solution you'd like
The OpenSearch is using Apache Lucene 9.x release line for 3.x and 2.x release lines. We've never tried to integrate the Apache Lucene 10 (either as spike or to 3.0.0) but we probably should start doing that shortly.

Describe alternatives you've considered
Keep Apache Lucene 9.x

Additional context
Depends on #10745 since Apache Lucene 10 has JDK-21 baseline
@reta reta added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 30, 2023
@reta reta self-assigned this Nov 30, 2023
@reta reta added dependencies Pull requests that update a dependency file and removed untriaged labels Nov 30, 2023
@reta
Copy link
Collaborator Author

reta commented Nov 30, 2023

CC @msfroh @nknize @dblock @andrross

@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 and removed untriaged labels Nov 30, 2023
@nknize
Copy link
Collaborator

nknize commented Nov 30, 2023

I started this effort on a separate branch a long time ago shortly after finishing the multi month 9.0.0 upgrade - which was quite painful. 10.0.0 isn't as painful (since 9.0.0 had to deal w/ byte order changes) but there were JDK conflicts I need to resolve by rebasing to main. I'll take care of that and throw it on a feature branch if others want to contribute so we're not redoing the work I already did.

@nknize
Copy link
Collaborator

nknize commented Nov 30, 2023

There's a 10.0 snapshot already but it's quite stale. Feel free to kick off a new one from lucene's main branch.

@reta reta mentioned this issue Jan 31, 2024
Closed
@bbarani
Copy link
Member

bbarani commented Feb 6, 2024

@reta @nknize can you please confirm if this change can be included in 2.x without breaking existing API? Basically can this change be added in a backward compatible manner in 2.x line?

We are evaluating if this change requires 3.0 release or can be included in 2.x line so need your inputs.

@reta
Copy link
Collaborator Author

reta commented Feb 6, 2024 •
edited
Loading

@reta @nknize can you please confirm if this change can be included in 2.x without breaking existing API? Basically can this change be added in a backward compatible manner in 2.x line?

@bbarani This is a Apache Lucene change - it will break every single plugin / extension sadly.

@reta reta mentioned this issue Mar 11, 2024
Open
19 tasks
@jed326
Copy link
Collaborator

jed326 commented Oct 15, 2024

Another major change to explore: apache/lucene#13337

@reta reta changed the title [FEATURE] Explore the update route to Apache Lucene 10 for 3.0.0 [FEATURE] Update to Apache Lucene 10 for 3.0.0 Oct 16, 2024
@reta reta linked a pull request Oct 17, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reta reta

Labels
dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Update to Apache Lucene 10 for 3.0.0 reta/OpenSearch
4 participants
@reta @nknize @jed326 @bbarani