Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Cleanup] Potentially remove not needed MultiTermQueryBuilder interface #15487

Open
jainankitk opened this issue Aug 29, 2024 · 0 comments
Open

[Code Cleanup] Potentially remove not needed MultiTermQueryBuilder interface #15487

jainankitk opened this issue Aug 29, 2024 · 0 comments
Assignees
@jainankitk
Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc

Comments

@jainankitk
Copy link
Collaborator

Is your feature request related to a problem? Please describe

With the introduction of fieldName within AbstractQueryBuilder as part of #15328, do we really need the MultiTermQueryBuilder interface anymore?

Describe the solution you'd like

MultiTermQueryBuilder can be removed since AbstractQueryBuilder enforces implementation of fieldName for all Query Builders

Related component

Search

Describe alternatives you've considered

No response

Additional context

No response
@jainankitk jainankitk added enhancement Enhancement or improvement to existing feature or request untriaged good first issue Good for newcomers labels Aug 29, 2024
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Aug 29, 2024
@mch2 mch2 added discuss Issues intended to help drive brainstorming and decision making and removed good first issue Good for newcomers untriaged labels Sep 4, 2024
@jainankitk jainankitk mentioned this issue Sep 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jainankitk jainankitk

Labels
discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request Search Search query, autocomplete ...etc
Projects
Search Project Board
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mch2 @jainankitk