ListFirstAndLast skips methodCall().get(0)

[timo-abele]

What version of OpenRewrite are you using?

see below

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

      <plugin>
        <groupId>org.openrewrite.maven</groupId>
        <artifactId>rewrite-maven-plugin</artifactId>
        <version>5.22.0</version>
        <configuration>
          <activeRecipes>
            <recipe>org.openrewrite.java.migrate.UpgradeToJava21</recipe>
          </activeRecipes>
        </configuration>
        <dependencies>
          <dependency>
            <groupId>org.openrewrite.recipe</groupId>
            <artifactId>rewrite-migrate-java</artifactId>
            <version>2.8.0</version>
          </dependency>
        </dependencies>
      </plugin>

What is the smallest, simplest way to reproduce the problem?

class A {
  class Inner {

    @Getter
    private List<String> listOne = new ArrayList<>();

  }

  void getFirst(){
    Inner inner = new Inner();
    inner.getListOne().get(0);
  }
}

It doesn't have to be an inner class, I'm just not sure if a sequence of classes as a string works in tests.

What did you expect to see?

class A {
  class Inner {

    @Getter
    private List<String> listOne = new ArrayList<>();

  }

  void getFirst(){
    Inner inner = new Inner();
    inner.getListOne().getFirst();
  }
}

What did you see instead?

no change

What is the full stack trace of any errors you encountered?

stacktrace output here

Are you interested in contributing a fix to OpenRewrite?

[timtebeek]

Ah yes those will have missing type information unfortunately, as we don't yet support Lombok annotations:

• Support Lombok Annotations rewrite#1297

Not something specific to this recipe, so perhaps best tracked in the above issue.

[timo-abele]

Correction: It's not about lombok! Explicit getters don't work either:

class A{
  class Inner {

    public List<String> getListOne() {
      return listOne;
    }

    private List<String> listOne = new ArrayList<>();

  }

  void getFirst(){
    Inner inner = new Inner();
    inner.getListOne().get(0); //is ignored
    List<String> other = inner.getListOne();
    other.get(0); //is converted

  }

}

Skimming through my code everytime it is converted the pattern is variable.get(0).
And every time it is not converted the pattern is .methodCall().get(0).

[timtebeek]

Ah that's helpful, thanks! We should be able to create a test from your example above and then work out the steps needed to make this work.

[timtebeek]

You're right; there's a strong overfit on the recipe to particular cases; this expands that a bit with more overfit, but we likely can relax the constraints a bit to cover more cases. Thanks for chiming in!

• Expand ListFirstAndLast covered cases to include getList().get(0) #424